From owner-cvs-all Mon Apr 30 2:33:55 2001 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-27.dsl.lsan03.pacbell.net [63.207.60.27]) by hub.freebsd.org (Postfix) with ESMTP id 5121437B423; Mon, 30 Apr 2001 02:33:49 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id EBD6E66D82; Mon, 30 Apr 2001 02:33:47 -0700 (PDT) Date: Mon, 30 Apr 2001 02:33:47 -0700 From: Kris Kennaway To: Akinori MUSHA Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/fox/files patch-ad Message-ID: <20010430023347.A70094@xor.obsecurity.org> References: <200104300810.f3U8AGY60114@freefall.freebsd.org> <86elua4wf1.wl@archon.local.idaemons.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <86elua4wf1.wl@archon.local.idaemons.org>; from knu@iDaemons.org on Mon, Apr 30, 2001 at 05:35:46PM +0900 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2001 at 05:35:46PM +0900, Akinori MUSHA wrote: > At Mon, 30 Apr 2001 01:10:16 -0700 (PDT), > kkenn wrote: > > kris 2001/04/30 01:10:16 PDT > >=20 > > Modified files: > > x11-toolkits/fox/files patch-ad=20 > > Log: > > Don't hard-code -O2 and various -f optimizations in CXXFLAGS > > =20 > > Revision Changes Path > > 1.2 +37 -5 ports/x11-toolkits/fox/files/patch-ad >=20 > Thanks, but I wasn't asked for a review in advance on this... At a > glance, I noticed that /usr/local was hardcoded, which might be evil. >=20 > Also, I haven't yet tested if this big monster of a toolkit works with > optimization flags other than "-O2 -ffast-math -finline-functions > -fomit-frame-pointer -fexpensive-optimizations". I wish you had > pointed it to me rather than just committing directly. Well, the policy from all quarters of the project is that everything over -O is dangerous and is known to break. I tested compilation of all of the patches I've been committing today, but since I've just been making ports conform to accepted rules I didn't see the need to send each and every patch through maintainers (that would have at least doubled the total time it would take me to get through these). For a couple of the ports I came across functional (non-style) changes which should be made; those I bounced to the maintainers for approval. Basically I think the approach we should be taking wrt -O2 and so on is that people should need to justify why their port should default to add anything of the sort to the user-supplied values. It's (almost) never a good idea. I take full responsibility for any errors I caused during this series of commits. It looks like the /usr/local thing snuck through unexpectedly in this case; I've already fixed it and will go back and re-check the others. Kris --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.5 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE67TF7Wry0BWjoQKURAsrzAKDRymQdHvGyx2XncJ6pTvVkTkka5ACgicM1 1eEcSXADcafrvpIM04SECHo= =bVst -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message