From owner-svn-src-all@FreeBSD.ORG Tue Mar 31 16:19:44 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17E1B217; Tue, 31 Mar 2015 16:19:44 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BDBF0C74; Tue, 31 Mar 2015 16:19:43 +0000 (UTC) Received: from Julian-MBP3.local (ppp121-45-255-201.lns20.per4.internode.on.net [121.45.255.201]) (authenticated bits=0) by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t2VGJW3w019861 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 31 Mar 2015 09:19:38 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <551AC90E.3070109@freebsd.org> Date: Wed, 01 Apr 2015 00:19:26 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eric van Gyzen , John Baldwin , Randall Stewart Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <32487399.PTq7ESkWJT@ralph.baldwin.cx> <26047F0C-A975-4DAC-9077-31B5EC4902DA@netflix.com> <5710983.pHS9DoOdY8@ralph.baldwin.cx> <551AC4BF.40106@FreeBSD.org> In-Reply-To: <551AC4BF.40106@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 16:19:44 -0000 On 4/1/15 12:01 AM, Eric van Gyzen wrote: >>> Now as to the >>> >>> -1 -> NOCPU >>> >>> This is like pulling on a string on your sweater.. the only sensible solution that >>> I could come up with after chatting with Lawrence is to add >>> #include >>> to everyone that uses the callout.h and does not have it already… (putting it into callout.h does not work) .. sigh.. >>> >>> Now for this cosmetic change I end up with the following changes (and as yet I have >>> not built LINT or universe so there may be more).. I have spent about 2 hours on this >>> so far and I can at least build a kernel with the change for amd64 :-0 >>> >>> Here is what has to change, do you really think that this is worth it? >>> >>> Note I did not look into moving NOCPU in proc.h it says it means no CPU is present >>> which is sort of the meaning we want.. I am not sure if the define could be moved .. but >>> that too may be yet another string... >>> >>> Is this worth it, or do you have another idea on how best to do this??? >> Ugh. :( I guess leave it at -1 for now. > If you leave it as -1, you might add a /* NOCPU */ comment, for the sake of > grep. (This could be a lost cause, for all I know, but it can't hurt.) > >> Another alternative would be to >> move NOCPU to (at least for the kernel) if bde@ would allow it. >> I don't think changing all those files is appropriate. >> >> (Also, seems like an odd place for NOCPU now, it should really be >> in if not param.h. I understand why it was first added in proc.h, >> but it is now used in many more places than just td_oncpu.) > +1 move it.. I think I may have added it for td_oncpu but I'm not going to look it up. > > Eric > > >