From owner-svn-src-all@FreeBSD.ORG Wed Jan 28 20:50:49 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 804D01065902 for ; Wed, 28 Jan 2009 20:50:49 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.225]) by mx1.freebsd.org (Postfix) with ESMTP id 4CC428FC14 for ; Wed, 28 Jan 2009 20:50:49 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so7244958rvf.43 for ; Wed, 28 Jan 2009 12:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=m9HlUYUKN0lAUaEk/GYm0/s8NzVcDxmkvg/TLiUy08g=; b=kv56XBJTbBH5I9YiNI3QZwhVaMEEqBdgJT+6jz4WNjhHcW2ZEnGUN9l9mVLJKHhZiC K8fo6wKqDLZftkVExBXOWPKyRbiz1bBYbccnsFd2h0upnwLQQQhnJD/9ZyPCW69KjmPA giO+CgfZUHhmkw575d4iTkL6WXrjkv9pW34Ek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=OvoLmhnc0EHqhBb7WM4PaAfu0rh5hK046uyctC+7se1UTedmcBCjNyrg/0Lv4hfZe8 cq0hDsVALB9eXVGU3M1PT+dN1rI9NQVpMbe19x6z6c4vP5qcEFN3MjNIpk1Eumg8/cUC DPZ/S12G4+ZuymuAVE3X8Ep2zfsyRptZNfsa4= MIME-Version: 1.0 Sender: maksim.yevmenkin@gmail.com Received: by 10.141.113.6 with SMTP id q6mr3517996rvm.212.1233174384677; Wed, 28 Jan 2009 12:26:24 -0800 (PST) In-Reply-To: <20090128201842.GD41780@citylink.fud.org.nz> References: <200901282006.n0SK62pa032130@svn.freebsd.org> <20090128201842.GD41780@citylink.fud.org.nz> Date: Wed, 28 Jan 2009 12:26:24 -0800 X-Google-Sender-Auth: 17c369e818e2363e Message-ID: From: Maksim Yevmenkin To: Andrew Thompson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187866 - head/sys/dev/usb2/bluetooth X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 20:50:50 -0000 On Wed, Jan 28, 2009 at 12:18 PM, Andrew Thompson wrote: > On Wed, Jan 28, 2009 at 08:06:02PM +0000, Maksim Yevmenkin wrote: >> Author: emax >> Date: Wed Jan 28 20:06:02 2009 >> New Revision: 187866 >> URL: http://svn.freebsd.org/changeset/base/187866 >> >> Log: >> Update ubtbcmfw2 (aka usb2_bluetooth_fw) driver >> >> Reviewed by: HPS >> >> enum { >> - UBTBCMFW_BULK_DT_WR, >> - UBTBCMFW_BULK_DT_RD, >> - UBTBCMFW_BULK_CS_WR, >> - UBTBCMFW_BULK_CS_RD, >> - UBTBCMFW_N_TRANSFER = 4, >> + UBTBCMFW_BULK_DT_WR = 0, >> + UBTBCMFW_INTR_DT_RD, >> + UBTBCMFW_N_TRANSFER, >> }; > > I found it more useful the other way around which showed the number of > transfers at a glance of UBTBCMFW_N_TRANSFER. (I realise you removed one) two actually. all transfer stalls are now handled internally (as per HPSs suggestion). in any case, it seemed like a good idea to do it this way because those values used as indexes to an array. just wanted to make sure that all transfers are in their right places :) dont really have a particularly strong opinion on this though :) and its only 2 values we are talking about here :) thanks, max