From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Sep 1 21:00:05 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A66F106568D for ; Tue, 1 Sep 2009 21:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 145CA8FC21 for ; Tue, 1 Sep 2009 21:00:05 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n81L04Z3056686 for ; Tue, 1 Sep 2009 21:00:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n81L0446056685; Tue, 1 Sep 2009 21:00:04 GMT (envelope-from gnats) Resent-Date: Tue, 1 Sep 2009 21:00:04 GMT Resent-Message-Id: <200909012100.n81L0446056685@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Neil Darlow Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EDE94106566C for ; Tue, 1 Sep 2009 20:54:03 +0000 (UTC) (envelope-from neil@darlow.co.uk) Received: from mtaout02-winn.ispmail.ntl.com (mtaout02-winn.ispmail.ntl.com [81.103.221.48]) by mx1.freebsd.org (Postfix) with ESMTP id 4A0808FC21 for ; Tue, 1 Sep 2009 20:54:02 +0000 (UTC) Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090901205401.XVSN6611.mtaout02-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com> for ; Tue, 1 Sep 2009 21:54:01 +0100 Received: from router.darlow.co.uk ([82.1.192.202]) by aamtaout04-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090901205401.JPGB22934.aamtaout04-winn.ispmail.ntl.com@router.darlow.co.uk> for ; Tue, 1 Sep 2009 21:54:01 +0100 Received: from router.darlow.co.uk (localhost [127.0.0.1]) by router.darlow.co.uk (Postfix) with ESMTP id 77B2F102CD6 for ; Tue, 1 Sep 2009 21:54:01 +0100 (BST) Received: by router.darlow.co.uk (Postfix, from userid 1001) id 354AB102C65; Tue, 1 Sep 2009 21:54:01 +0100 (BST) Message-Id: <20090901205401.354AB102C65@router.darlow.co.uk> Date: Tue, 1 Sep 2009 21:54:01 +0100 (BST) From: Neil Darlow To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/138461: net/isc-dhcp31-server rcNG script has syntax errors X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Neil Darlow List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2009 21:00:05 -0000 >Number: 138461 >Category: ports >Synopsis: net/isc-dhcp31-server rcNG script has syntax errors >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 01 21:00:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Neil Darlow >Release: FreeBSD 7.2-RELEASE-p3 i386 >Organization: >Environment: System: FreeBSD router.darlow.co.uk 7.2-RELEASE-p3 FreeBSD 7.2-RELEASE-p3 #0: Wed Jul 29 19:55:32 BST 2009 root@router.darlow.co.uk:/usr/obj/usr/src/sys/ROUTER i386 >Description: The sed expression processing $rc_flags contains two errors: 1) Use of $(rc_flags) where ${rc_flags} is intended 2) Misplaced ' character in -q$)'//` where -q$)'//` is intended Additionally, there is an echo command for $rc_flags which has probably been left behind from debugging. >How-To-Repeat: Restart isc-dhcpd and note output produced. >Fix: Patch follows. --- isc-dhcpd.orig 2009-08-31 21:36:24.000000000 +0100 +++ isc-dhcpd 2009-09-01 21:40:31.000000000 +0100 @@ -706,9 +706,8 @@ setup_flags rc_flags_mod="$rc_flags" # Eliminate '-q' flag if it is present - echo $rc_flags case "$rc_flags" in - *-q*) rc_flags_mod=`echo "$(rc_flags)" | sed -Ee 's/(^-q | -q | -q$)'//` ;; + *-q*) rc_flags_mod=`echo "${rc_flags}" | sed -Ee 's/(^-q | -q | -q$)//'` ;; esac if ! ${command} -t -q ${rc_flags_mod}; then err 1 "`${command} -t ${rc_flags_mod}` Configuration file sanity check failed" >Release-Note: >Audit-Trail: >Unformatted: