From nobody Wed Feb 5 20:53:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpC9s651tz5mNSX; Wed, 05 Feb 2025 20:53:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpC9s5KR0z3SkB; Wed, 05 Feb 2025 20:53:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738788785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sbxSVb6Xj7g+ZgyEkX/IoOdQEQ5dnupi6CVtSW2M3h4=; b=YsLRT5KUD1ZlmoBNJmMjUUaUvG7K67QZu+crmb9Zcvb5tH7DNOjf5CsLLsXQ41v/CG5BZv UveGvT1fkRZnnQj9dUImOmND/SaM6B6iVlX0yaqpVTSBPdgUz0xNzhA+xuhL+NMBTfLcTr mtRjcPgpzFM5MVPMSopkvGSZMh7IQNUIS4Hscl/Wq3tpqv6iLtjAHzQZcdhj3BrERI2oMP f4YMAeUR27teZ/NdBTGUiGf7KWRNonz2sTAFVityhMjDUNoXZXmpfxIPBglwzWS4dNgQp1 kCFRW1PvmDty0eUKSpACKoOEAtgCWwZRkQUGtHzuT1E+er18qbtS4N2gBDBQCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738788785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sbxSVb6Xj7g+ZgyEkX/IoOdQEQ5dnupi6CVtSW2M3h4=; b=LOeq6b3yHNiYmTcreAMytBxjR49gP6q9fumBtf1ri0ysalX+MxWYiSMagHEV2ox6L052zB 94Go1P0msixhkieVB4JASwn0c8ywMQdeLF9U3OXRdbwRh78K0BVDHeMzDmfT6iM/QLgxjX g6SvtVkR0lJ0v/ghqPcfTyHl7j7JL7zAkYlx0PzzUJ7myCcGnk36RCRd4b0aIxhuANpy6m YKS8e12g/nOOemm7h8nG2cc3p5gC7XKAa+J2rK0XsMnAKtbgUSxB8Jn1MoJ7rfA4o1ZMUT vKbw6CEa5oQsjeT6ae2w+0SfoWDA2uA06RauPnQLqk+0JtRGfnrhAqjk8kKu1A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738788785; a=rsa-sha256; cv=none; b=w44KAzbo5Mmweh+2/y7/39oydjnDaufEIH/VLGbUe5alVjwVLmZ+/btSkfakLNDS0Tkv61 CLU2syVMt95odOFgEnfJLQ00DYQRnbG9uIMzmluv7WsjqKj48GKBxSC/tBIb3rhUNw8eWh aX6yDhq0Aio1CeQxAT5+QGMGNF8Ii7GHCf3970zftBBqEIPdXD50kPlx6qoOQ5udWy6hWy H/ar7bIPgUxEVz5Psd80OTD4NA98OPbaAhhno1Zkcefz9Ql71Z8A+pqDLsx0Va7LCx6amH S5Wd4s67a9mHVENlTRj/YicdS/DggffsbzjwwFP1p8BRkiSuRavP3H56Dsu8/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YpC9s4mQtz16wM; Wed, 05 Feb 2025 20:53:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515Kr5Y1003107; Wed, 5 Feb 2025 20:53:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515Kr5Vq003104; Wed, 5 Feb 2025 20:53:05 GMT (envelope-from git) Date: Wed, 5 Feb 2025 20:53:05 GMT Message-Id: <202502052053.515Kr5Vq003104@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 1d8bbe5ba370 - stable/14 - TCP RACK: remove variable with is only initialized and not changed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1d8bbe5ba370f909192818d3be9075caa5fb0730 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=1d8bbe5ba370f909192818d3be9075caa5fb0730 commit 1d8bbe5ba370f909192818d3be9075caa5fb0730 Author: Michael Tuexen AuthorDate: 2025-01-04 20:11:26 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 09:52:35 +0000 TCP RACK: remove variable with is only initialized and not changed minslot is initialized to 0 and never changed. It is not clear to me under which condition minslot should be set to which value. Therefore, remove it and the code checking that it is not zero. No functional change intended. Reviewed by: rrs CID: 1523812 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48321 (cherry picked from commit 84e894ce1309b426aa5d1a20ec194401f35dc478) --- sys/netinet/tcp_stacks/rack.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index a8542c093f74..c9fd18be1ede 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17681,7 +17681,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str { uint64_t srtt; int32_t slot = 0; - int32_t minslot = 0; int can_start_hw_pacing = 1; int err; int pace_one; @@ -18013,11 +18012,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str } } } - if (minslot && (minslot > slot)) { - rack_log_pacing_delay_calc(rack, minslot, slot, rack->r_ctl.crte->rate, bw_est, lentim, - 98, __LINE__, NULL, 0); - slot = minslot; - } done_w_hdwr: if (rack_limit_time_with_srtt && (rack->use_fixed_rate == 0) &&