From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Sep  9 13:17:31 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5A445A
 for <freebsd-ports-bugs@FreeBSD.org>; Tue,  9 Sep 2014 13:17:31 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4118A9B8
 for <freebsd-ports-bugs@FreeBSD.org>; Tue,  9 Sep 2014 13:17:31 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s89DHVnX080221
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 9 Sep 2014 13:17:31 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 193474] security/webshag: some ports improvements.
Date: Tue, 09 Sep 2014 13:17:31 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jhale@FreeBSD.org
X-Bugzilla-Status: In Discussion
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: jhale@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status cc assigned_to
Message-ID: <bug-193474-13-vwPtq3iTEw@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193474-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-193474-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Sep 2014 13:17:31 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193474

Jason E. Hale <jhale@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Triage                |In Discussion
                 CC|                            |jhale@FreeBSD.org
           Assignee|freebsd-ports-bugs@FreeBSD. |jhale@FreeBSD.org
                   |org                         |

--- Comment #2 from Jason E. Hale <jhale@FreeBSD.org> ---
Patch looks fine for the issues that were brought up, but there are other
issues that should have been addressed before this port was added:

- webshag.conf should probably be installed as webshag.conf.sample and use the
@sample keyword in pkg-plist so that edited configs don't get overwritten.
- patch-setup_linux_py uses hard-coded paths for PREFIX and LOCALBASE...this
should be fixed.  You could use %%PREFIX%% and %%LOCALBASE%% in the patch
instead, then use a post-patch replacement.
- Python bytecode should be pre-generated with and without the -O flag (.pyo
and .pyc files) for everything installed in PYTHON_SITELIBDIR so there are no
leftovers.

-- 
You are receiving this mail because:
You are the assignee for the bug.