From nobody Wed Mar 29 13:52:46 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pmp0M65J8z42b4W; Wed, 29 Mar 2023 13:52:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pmp0M4N57z4Kyr; Wed, 29 Mar 2023 13:52:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-x12b.google.com with SMTP id h11so8122591ild.11; Wed, 29 Mar 2023 06:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680097970; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=zfvYxev3GCh3RpStEod3wZtvwyEunBn/adYxI9iwgas=; b=TMKNEvPhGiZEX5izKmxoDVRW+62Id55smUMGf/Dw/j++Vj2h5SaSP8CwWuD8uuC3u4 9UkOndA0mSnMa9TlASQpQBShjz8KxJpwAxPkkEGHtmx7vkbPeWqMOkEJ/dl6Crx2vg09 qTaET6ymg4ltknno/nkQjI0eURRdESPFMGYg3D3ttyqarBwZx2Sjwy+9PWyz5nm1FUyP gDilS8dTNhOQ/KI3eyxdCorOIoiGkPRklS80WGBIUQJAzDZAilM112j99tbhzmiCpGnl nHawAJ95NKL48dNLCFZLzfWbbRQHEzTtG13Zap3yr3taV82T7PkZPoGAqcyvrYmTnN2z KUaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680097970; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zfvYxev3GCh3RpStEod3wZtvwyEunBn/adYxI9iwgas=; b=F//GghhXW9+a+a1NeJI09hGjpBkveaKbmPo0v5urOI+O33o7CNF2zv4rhDnePHJWKD F92VaA0AAmuflSSAPNkJCd52vsiiVwPrhHobOGFyK69WYqOPT/VAd14pJdmaxfL3IJdz C/pROCZJg2bl+JPkKQr9raC2bmCCpD0J6Jbl7i2o0HfBGLyhspckutQuU9LJMUdHthG+ LqMvIo4ylFfQ08etw2mF1C9cNXvXHFRPB7zaZRjZkkE3TIxMJ8mgDqLDFIGmPtSDcT46 yWf5BHT0qNdkglPMw+ossMC0eniZAkIy6w8ACgctSmYsgjwWCOTZFm+dfBFCwtUiIFEe J1VA== X-Gm-Message-State: AAQBX9diOQ0KryP+3PRcQ0yJjEyaYEHYwDRQfptZrkza+TFxE/UBZ+Ve LT+88TG0LYw19G6hZdIGMCxgYBNbL4w= X-Google-Smtp-Source: AKy350bkbCi3V3Sa0qHkszmy62kWyzNpjCEXMYayXdq5Tg/lUtJqgUv/hlkq+QhRg0zMjKY6broHCw== X-Received: by 2002:a92:c104:0:b0:325:b60b:e309 with SMTP id p4-20020a92c104000000b00325b60be309mr14032418ile.4.1680097969799; Wed, 29 Mar 2023 06:52:49 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id q10-20020a056e020c2a00b00316e54a8287sm9408397ilg.14.2023.03.29.06.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 06:52:49 -0700 (PDT) Date: Wed, 29 Mar 2023 09:52:46 -0400 From: Mark Johnston To: Corvin =?iso-8859-1?Q?K=F6hne?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cff482380436 - main - bhyve: Move libcasper dependecy to lib9p Message-ID: References: <202303071613.327GDYuO057215@gitrepo.freebsd.org> <18d0b6ee177ba4d84f0f355c06707f494e99f640.camel@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <18d0b6ee177ba4d84f0f355c06707f494e99f640.camel@FreeBSD.org> X-Rspamd-Queue-Id: 4Pmp0M4N57z4Kyr X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, Mar 29, 2023 at 03:42:21PM +0200, Corvin Köhne wrote: > On Tue, 2023-03-07 at 16:13 +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=cff4823804363cf199c7c87eed8870ad014066cc > > > > commit cff4823804363cf199c7c87eed8870ad014066cc > > Author:     Vitaliy Gusev > > AuthorDate: 2023-03-07 16:09:22 +0000 > > Commit:     Mark Johnston > > CommitDate: 2023-03-07 16:09:22 +0000 > > > >     bhyve: Move libcasper dependecy to lib9p > >     > >     libcasper(3) is not used in bhyve. So move dependency to the > > appropriate > >     place. > >     > >     Reviewed by:    markj > >     MFC after:      1 week > >     Sponsored by:   vStack > >     Differential Revision:  https://reviews.freebsd.org/D38905 > > --- > >  lib/lib9p/Makefile       | 5 +++-- > >  share/mk/src.libnames.mk | 4 ++++ > >  usr.sbin/bhyve/Makefile  | 8 -------- > >  3 files changed, 7 insertions(+), 10 deletions(-) > > [...] > > Hi Mark, > > I do get build failures for my latest commits. The build log contains: > > /usr/local/bin/x86_64-unknown-freebsd13.1-ld: > /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined > reference to `cap_setpassent' > /usr/local/bin/x86_64-unknown-freebsd13.1-ld: > /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined > reference to `cap_getgrgid_r' > /usr/local/bin/x86_64-unknown-freebsd13.1-ld: > /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined > reference to `cap_setgroupent' > /usr/local/bin/x86_64-unknown-freebsd13.1-ld: > /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined > reference to `cap_getpwnam' > /usr/local/bin/x86_64-unknown-freebsd13.1-ld: > /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined > reference to `cap_getpwuid_r' > collect2: error: ld returned 1 exit status > > See > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/701/console > > It seems to be related to this commit. Any ideas how to fix it? John dug into this already and posted a series of different solutions: https://reviews.freebsd.org/D39213 https://reviews.freebsd.org/D39222 https://reviews.freebsd.org/D39245 The last one is probably the one that will end up being committed. In the meantime, the easiest workaround is probably to simply revert my commit.