From owner-svn-src-all@FreeBSD.ORG Fri Feb 24 17:57:26 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B9F910656E7; Fri, 24 Feb 2012 17:57:26 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail16.syd.optusnet.com.au (mail16.syd.optusnet.com.au [211.29.132.197]) by mx1.freebsd.org (Postfix) with ESMTP id 24AFE8FC22; Fri, 24 Feb 2012 17:57:25 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail16.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q1OHvNao001072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 25 Feb 2012 04:57:24 +1100 Date: Sat, 25 Feb 2012 04:57:23 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: John Baldwin In-Reply-To: <201202232108.q1NL8LeB023212@svn.freebsd.org> Message-ID: <20120225044912.Y2319@besplex.bde.org> References: <201202232108.q1NL8LeB023212@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232072 - head/usr.bin/kdump X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 17:57:26 -0000 On Thu, 23 Feb 2012, John Baldwin wrote: > Log: > Pretty-print the advice constants passed to posix_fadvise(2). > Modified: head/usr.bin/kdump/kdump.c > ============================================================================== > --- head/usr.bin/kdump/kdump.c Thu Feb 23 21:07:16 2012 (r232071) > +++ head/usr.bin/kdump/kdump.c Thu Feb 23 21:08:21 2012 (r232072) > @@ -1014,6 +1014,15 @@ ktrsyscall(struct ktr_syscall *ktr, u_in > } > capname(arg); > break; > + case SYS_posix_fadvise: > + print_number(ip,narg,c); > + print_number(ip,narg,c); > + print_number(ip,narg,c); > ... Any chance of prettyprinting the sources too? The (macro) definition was already uglyprinted, but kdump is fairly KNF-conformant (unlike truss), and doesn't use uglyprinting when invoking print_number() except for here. > Modified: head/usr.bin/kdump/mksubr > ============================================================================== > --- head/usr.bin/kdump/mksubr Thu Feb 23 21:07:16 2012 (r232071) > +++ head/usr.bin/kdump/mksubr Thu Feb 23 21:08:21 2012 (r232072) > @@ -340,6 +340,7 @@ auto_or_type "accessmodename" " > auto_switch_type "acltypename" "ACL_TYPE_[A-Z4_]+[[:space:]]+0x[0-9]+" "sys/acl.h" > auto_or_type "capname" "CAP_[A-Z]+[[:space:]]+0x[01248]{16}ULL" "sys/capability.h" > auto_switch_type "extattrctlname" "EXTATTR_NAMESPACE_[A-Z]+[[:space:]]+0x[0-9]+" "sys/extattr.h" > +auto_switch_type "fadvisebehavname" "POSIX_FADV_[A-Z]+[[:space:]]+[0-9]+" "sys/fcntl.h" > auto_or_type "flagsname" "O_[A-Z]+[[:space:]]+0x[0-9A-Fa-f]+" "sys/fcntl.h" > auto_or_type "flockname" "LOCK_[A-Z]+[[:space:]]+0x[0-9]+" "sys/fcntl.h" > auto_or_type "getfsstatflagsname" "MNT_[A-Z]+[[:space:]]+[1-9][0-9]*" "sys/mount.h" It's hard to avoid uglyprinting here. The regexps alone make it unreadable. Bruce