Date: Sat, 25 Feb 2012 04:57:23 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232072 - head/usr.bin/kdump Message-ID: <20120225044912.Y2319@besplex.bde.org> In-Reply-To: <201202232108.q1NL8LeB023212@svn.freebsd.org> References: <201202232108.q1NL8LeB023212@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 23 Feb 2012, John Baldwin wrote:
> Log:
> Pretty-print the advice constants passed to posix_fadvise(2).
> Modified: head/usr.bin/kdump/kdump.c
> ==============================================================================
> --- head/usr.bin/kdump/kdump.c Thu Feb 23 21:07:16 2012 (r232071)
> +++ head/usr.bin/kdump/kdump.c Thu Feb 23 21:08:21 2012 (r232072)
> @@ -1014,6 +1014,15 @@ ktrsyscall(struct ktr_syscall *ktr, u_in
> }
> capname(arg);
> break;
> + case SYS_posix_fadvise:
> + print_number(ip,narg,c);
> + print_number(ip,narg,c);
> + print_number(ip,narg,c);
> ...
Any chance of prettyprinting the sources too? The (macro) definition
was already uglyprinted, but kdump is fairly KNF-conformant (unlike
truss), and doesn't use uglyprinting when invoking print_number()
except for here.
> Modified: head/usr.bin/kdump/mksubr
> ==============================================================================
> --- head/usr.bin/kdump/mksubr Thu Feb 23 21:07:16 2012 (r232071)
> +++ head/usr.bin/kdump/mksubr Thu Feb 23 21:08:21 2012 (r232072)
> @@ -340,6 +340,7 @@ auto_or_type "accessmodename" "
> auto_switch_type "acltypename" "ACL_TYPE_[A-Z4_]+[[:space:]]+0x[0-9]+" "sys/acl.h"
> auto_or_type "capname" "CAP_[A-Z]+[[:space:]]+0x[01248]{16}ULL" "sys/capability.h"
> auto_switch_type "extattrctlname" "EXTATTR_NAMESPACE_[A-Z]+[[:space:]]+0x[0-9]+" "sys/extattr.h"
> +auto_switch_type "fadvisebehavname" "POSIX_FADV_[A-Z]+[[:space:]]+[0-9]+" "sys/fcntl.h"
> auto_or_type "flagsname" "O_[A-Z]+[[:space:]]+0x[0-9A-Fa-f]+" "sys/fcntl.h"
> auto_or_type "flockname" "LOCK_[A-Z]+[[:space:]]+0x[0-9]+" "sys/fcntl.h"
> auto_or_type "getfsstatflagsname" "MNT_[A-Z]+[[:space:]]+[1-9][0-9]*" "sys/mount.h"
It's hard to avoid uglyprinting here. The regexps alone make it unreadable.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120225044912.Y2319>