From owner-svn-src-head@FreeBSD.ORG Thu Mar 29 23:30:17 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C645F106564A; Thu, 29 Mar 2012 23:30:17 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B11E18FC08; Thu, 29 Mar 2012 23:30:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q2TNUHrr014845; Thu, 29 Mar 2012 23:30:17 GMT (envelope-from dim@svn.freebsd.org) Received: (from dim@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q2TNUHbu014843; Thu, 29 Mar 2012 23:30:17 GMT (envelope-from dim@svn.freebsd.org) Message-Id: <201203292330.q2TNUHbu014843@svn.freebsd.org> From: Dimitry Andric Date: Thu, 29 Mar 2012 23:30:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233683 - head/sys/x86/include X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 23:30:17 -0000 Author: dim Date: Thu Mar 29 23:30:17 2012 New Revision: 233683 URL: http://svn.freebsd.org/changeset/base/233683 Log: Revert sys/x86/include/endian.h to what it was before r233419, as that revision has two problems: - It can produce worse code with both clang and gcc. - It doesn't fix the actual issue introduced in r232721, which will be fixed in the next commit. Submitted by: bde, tijl and jh Pointy hat to: dim Modified: head/sys/x86/include/endian.h Modified: head/sys/x86/include/endian.h ============================================================================== --- head/sys/x86/include/endian.h Thu Mar 29 21:54:19 2012 (r233682) +++ head/sys/x86/include/endian.h Thu Mar 29 23:30:17 2012 (r233683) @@ -63,11 +63,11 @@ #define BYTE_ORDER _BYTE_ORDER #endif -#define __bswap16_gen(x) ((__uint16_t)((x) << 8 | (x) >> 8)) +#define __bswap16_gen(x) (__uint16_t)((x) << 8 | (x) >> 8) #define __bswap32_gen(x) \ - (((__uint32_t)__bswap16_gen(x) << 16) | __bswap16_gen((x) >> 16)) + (((__uint32_t)__bswap16(x) << 16) | __bswap16((x) >> 16)) #define __bswap64_gen(x) \ - (((__uint64_t)__bswap32_gen(x) << 32) | __bswap32_gen((x) >> 32)) + (((__uint64_t)__bswap32(x) << 32) | __bswap32((x) >> 32)) #ifdef __GNUCLIKE_BUILTIN_CONSTANT_P #define __bswap16(x) \