From owner-cvs-src@FreeBSD.ORG Sat Jun 26 23:13:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36B3A16A4CE; Sat, 26 Jun 2004 23:13:30 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD77043D2F; Sat, 26 Jun 2004 23:13:29 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i5QN9jZR036491; Sat, 26 Jun 2004 17:09:45 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 26 Jun 2004 17:10:02 -0600 (MDT) Message-Id: <20040626.171002.123619201.imp@bsdimp.com> To: le@freebsd.org From: "M. Warner Losh" In-Reply-To: <20040626203908.C666@korben.in.tern> References: <200406261312.i5QDCkmi062845@repoman.freebsd.org> <20040626203908.C666@korben.in.tern> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb uhid.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jun 2004 23:13:30 -0000 In message: <20040626203908.C666@korben.in.tern> Lukas Ertl writes: : On Sat, 26 Jun 2004, Lukas Ertl wrote: : : > Modified files: : > sys/dev/usb uhid.c : > Log: : > Our softc has no sc_hdev, but a sc_dev. This in turn has no direct : > sc_parent, so back out the previous commit, as it breaks the build. : : BTW, we should probably split up the uhid driver like NetBSD did with : uhidev. Agreed, to a point. There's a number of issues with how the ucom stuff was split out and I'd like to make sure that we don't repeat those mistakes... Warner