From owner-freebsd-current@FreeBSD.ORG Sun Aug 9 19:42:39 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64F261065670 for ; Sun, 9 Aug 2009 19:42:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 1183F8FC08 for ; Sun, 9 Aug 2009 19:42:38 +0000 (UTC) Received: (qmail 12755 invoked by uid 399); 9 Aug 2009 19:42:32 -0000 Received: from localhost (HELO ?192.168.0.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 9 Aug 2009 19:42:32 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A7F26A3.6000809@FreeBSD.org> Date: Sun, 09 Aug 2009 12:42:27 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: Kevin Oberman References: <20090809014748.284AB1CC31@ptavv.es.net> In-Reply-To: <20090809014748.284AB1CC31@ptavv.es.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: current@freebsd.org, bf@freebsd.org Subject: Re: Unable to build HEAD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Aug 2009 19:42:39 -0000 I'll let bf take the lead on this one. :) Doug Kevin Oberman wrote: >> Date: Wed, 05 Aug 2009 20:45:11 -0700 >> From: Doug Barton >> >> Kevin Oberman wrote: >> >>> OK. I cleaned out /usr/obj and saved /usr/src/sys/i386/conf. >> I'm going to assume that you mean just your conf file there. >> >> >>> While I >>> will have to re-do my kernel config, I prefer to save my old one, >> That's fine, just compare it to GENERIC to make sure that all of your >> entries are valid, and that you're not missing anything important. >> >>> But, as suggested by bf, I think that the WITHOUT_OPENSSH knob is >>> broken which is a problem >> Agreed. If you want to help debug this problem you could try building >> with clean /usr/obj, up to date /usr/src, and ONLY the ssh knob in >> src.conf. Then debug from there. >> >> This (IMWO) is something that should be fixed before release. >> >>> Guess I should have tried V8 a couple of months ago. >> In the immortal words of Jiminy Cricket, let your conscience be your >> guide. :) > > Doug, > > Two patches have been submitted to fix this problem, one by bf > (conf/137483) and one by me (conf/137486). I have confidence that the bf > patch is correct and appropriate and that buildworld is broken with > various src.conf options. I am convinced my patch is correct, > but I suspect that some might argue that it is not appropriate. It > allows pam_ssh to be built even though WITHOUT_OPENSSH is specified. > > I will be happy to defend my patch, if challenged, but the short time > until 8.0 makes it questionable as to whether a consensus can be reached > in time. Whether you like my patch, I'd love to see the patch by bf > (conf/137483) committed before 8.0 and I believe that you agree. If so, > could you request the RE to approve it to be committed.