From owner-svn-ports-head@FreeBSD.ORG  Sat Dec 29 17:37:38 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 490A3FE2;
 Sat, 29 Dec 2012 17:37:38 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id 15B8D8FC16;
 Sat, 29 Dec 2012 17:37:38 +0000 (UTC)
Received: from [192.168.173.14] (207.243.3.202.dsl.dyn.mana.pf [202.3.243.207])
 by ainaz.pair.com (Postfix) with ESMTPSA id CF5253F471;
 Sat, 29 Dec 2012 12:37:29 -0500 (EST)
Date: Sat, 29 Dec 2012 07:37:13 -1000 (TAHT)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Eitan Adler <eadler@freebsd.org>, Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: Remove unnecessary change to Mk/bsd.port.mk (: svn commit:
 r303619 - head/Mk)
In-Reply-To: <20121105081410.GE66354@ithaqua.etoilebsd.net>
Message-ID: <alpine.LNX.2.00.1212282212030.15650@tuna.site>
References: <201209032047.q83Kl1dl041630@svn.freebsd.org>
 <alpine.LNX.2.00.1209041827470.4718@trevally.site>
 <alpine.LNX.2.00.1211041507330.2266@tuna.site> <5097534E.8030604@FreeBSD.org>
 <20121105081410.GE66354@ithaqua.etoilebsd.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, Olli Hauer <ohauer@FreeBSD.org>,
 svn-ports-all@freebsd.org, portmgr@freebsd.org, ports-committers@freebsd.org,
 Max Khon <fjoe@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Dec 2012 17:37:38 -0000

On Sun, 4 Nov 2012, Eitan Adler wrote:
> On 4 November 2012 09:09, Gerald Pfeifer <gerald@pfeifer.com> wrote:
>> I understand Mk/bsd.port.mk is not applicable for maintainer
>> timeouts or I would have gone ahead and committed the patch
>> below.
> to change b.p.m please file a PR and request an exp-run

Well, my point was more that the original commit was problematic
and should be addressed, rather than me suggesting a change.

But, since the bogus change still is in Mk/bsd.port.mk, I now filed
  ports/174790
  Mk/bsd.port.mk: revert part of r303619, CPPFLAGS and LDFLAGS already are part of CONFIGURE_ENV
and hope portmgr@ is going to pick this up when they have a minute.

On Mon, 5 Nov 2012, Baptiste Daroussin wrote:
>> Maybe fjoe@ can explain why CONFIGURE_ENV was placed here.
>> The line was part of PR 162995.

I didn't see any explanation, but may have missed it?

> Speaking of this, USE_READLINE is anyway buggy, because it forces 
> linking over libreadline at first but to not take care of the related 
> ncurses, which could be the one from the ports or the one from base.

I also find the following interesting for such a general flag:

  CPPFLAGS+=		-I${LOCALBASE}/include
  LDFLAGS+=		-L${LOCALBASE}/lib -lreadline

Now, as some of you know, I have made the point that CPPFLAGS and
LDFLAGS should be set like this in general (and those hundreds, if
not thousands of ports doing so each on its own simplified accordingly).

To now see this as part of standard flag in bsd.mk.port, is interesting.

Gerald