Date: Sun, 04 Feb 2001 12:06:57 -0500 (EST) From: Mike Heffner <mheffner@vt.edu> To: Poul-Henning Kamp <phk@freebsd.org> Cc: audit@freebsd.org Subject: RE: if_multiaddrs.patch Message-ID: <XFMail.20010204120657.mheffner@vt.edu> In-Reply-To: <19497.981304817@critter>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks good to me. One thing I noticed was that in sys/pci/if_xl.c, functions
xl_setmulti() and xl_setmulti_hash(), the variable mcnt isn't needed and
TAILQ_EMPTY() could be used instead. In the following case, it would remove one
loop.
Index: pci/if_xl.c
===================================================================
RCS file: /home/ncvs/src/sys/pci/if_xl.c,v
retrieving revision 1.90
diff -u -r1.90 if_xl.c
--- pci/if_xl.c 2001/02/03 16:29:10 1.90
+++ pci/if_xl.c 2001/02/04 16:11:58
@@ -808,7 +808,7 @@
return;
}
- LIST_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link)
+ TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link)
mcnt++;
if (mcnt)
On 04-Feb-2001 Poul-Henning Kamp wrote:
|
| http://phk.freebsd.dk/patch
|
| 2001-02-04 if_multiaddrs.patch
|
| Convert if_multiaddrs from LIST to TAILQ so that it can
| be traversed backwards also.
|
| To be committed 2001-02-08
|
--
Mike Heffner <mheffner@vt.edu>
Blacksburg, VA ICQ# 882073
http://filebox.vt.edu/users/mheffner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010204120657.mheffner>