From owner-cvs-all Fri Feb 23 15:32:26 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id E41DB37B401; Fri, 23 Feb 2001 15:32:20 -0800 (PST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.2/8.11.2) with ESMTP id f1NNW3405802; Fri, 23 Feb 2001 23:32:03 GMT (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.2/8.11.2) with ESMTP id f1NNXuo05666; Fri, 23 Feb 2001 23:33:56 GMT (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200102232333.f1NNXuo05666@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Julian Elischer Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, brian@Awfulhak.org Subject: Re: cvs commit: src/share/man/man4 ng_pppoe.4 src/sys/netgraph netgraph.h ng_base.c ng_pppoe.c ng_pppoe.h ng_socket.c In-Reply-To: Message from Julian Elischer of "Fri, 23 Feb 2001 08:34:22 PST." <200102231634.f1NGYMV02734@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 23 Feb 2001 23:33:56 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > julian 2001/02/23 08:34:22 PST > > Modified files: > share/man/man4 ng_pppoe.4 > sys/netgraph netgraph.h ng_base.c ng_pppoe.c > ng_pppoe.h ng_socket.c > Log: > Shuffle sysctls a bit (thankyou whoever made them dynamic for modules) > and add a sysctl to pppoe to activate non standard ethertypes > so that idiot ISPs (apparently in France) who use > equipment from idiot suppliers (rumour says 3com) > who use nonstandard ethertypes can still connect. > > "yep, sure we do pppoe, we use a different identifier to that dictated in > the standard, but sure it's pppoe!" > > sysctl -w net.graph.stupid_isp=1 enables the changeover. Why (ab)use sysctls ? What if I want to have more than one PPPoE link but only have odd ethertypes on one ? Wouldn't a simple control message be more appropriate (although a bit more tricky to write as we'd need to understand a list of ethertypes) ? -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message