From owner-cvs-all@FreeBSD.ORG Wed Feb 23 06:41:34 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 661F116A4CE; Wed, 23 Feb 2005 06:41:34 +0000 (GMT) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 494C043D39; Wed, 23 Feb 2005 06:41:33 +0000 (GMT) (envelope-from jroberson@chesapeake.net) Received: from mail.chesapeake.net (localhost [127.0.0.1]) by mail.chesapeake.net (8.12.10/8.12.10) with ESMTP id j1N6f2v8097528; Wed, 23 Feb 2005 01:41:02 -0500 (EST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost)j1N6f1cH097524; Wed, 23 Feb 2005 01:41:02 -0500 (EST) (envelope-from jroberson@chesapeake.net) X-Authentication-Warning: mail.chesapeake.net: jroberson owned process doing -bs Date: Wed, 23 Feb 2005 01:41:01 -0500 (EST) From: Jeff Roberson To: Poul-Henning Kamp In-Reply-To: <58139.1109140240@critter.freebsd.dk> Message-ID: <20050223014018.Y52537@mail.chesapeake.net> References: <58139.1109140240@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys vnode.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2005 06:41:34 -0000 On Wed, 23 Feb 2005, Poul-Henning Kamp wrote: > In message <20050222180223.V52537@mail.chesapeake.net>, Jeff Roberson writes: > >On Tue, 22 Feb 2005, Poul-Henning Kamp wrote: > > > >> phk 2005-02-22 18:49:03 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/sys vnode.h > >> Log: > >> Group the fields in struct vnode by their function and stick comments > >> there to tell what the function is. > > > >They were sorted according to the lock that they used. I still prefer > >that, prehaps with sorting by use secondly. > > That doesn't make sense. The comment says which lock they use so people > can still see that, but appearantly people had big trouble seeing what > fields belonged where. It was so that we minimize cache hits, and cause a minimum number of synchronized writes when we release the mutex. > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. >