From nobody Thu Dec 18 03:50:28 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dWxXM1smBz6K7bk; Thu, 18 Dec 2025 03:50:43 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dWxXM1NZtz46hn; Thu, 18 Dec 2025 03:50:43 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766029843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u/uME6NkYCQ+5smfCU5J4w03XGPf9/dK8d/nfIrwdmg=; b=v+NAAOL4gGkhF0aSEEy4bXN9FrFR/tfqM5B8wGC0z/PLj6RTKomrjCTSDa8K9tBBzsSFn8 eXs23OeOR3UMWcf7x9h7vxdeGB/XiIxyutLbNNnqd9cwjRXmkhwBJ27zavHNMTtuLSUF7a Z49+FcBMgYP3E7c0GFJLhapk0l2OYnkEm3VZ7x85VAPIQtq5N0glhE6Zx90XeXhgc75mZH 986ONg+MOxOVqFYj9KFpCJGTC3Z9lXed3G/tkwt+YxBK0aKFZtEiHCYFVQ2uqw3MaSHVbJ +/YmgSVOvlZg1IUVHVlOcJAJoU0OsmZipwzbwEtMiYM3J4E3Lj4ZwsbaYFIgmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766029843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u/uME6NkYCQ+5smfCU5J4w03XGPf9/dK8d/nfIrwdmg=; b=l2OGQGTZ0V+sXVM3YEWJ3NHgrSEuZvDPAkpm1lzaAFVdZTy9B8lmLG6yiZjWMhs07VofWv CxmhOktaW7HsZTIbQ05k6hkGGsoPWpedhebRS7mKIJE/9uc8MoQCwwgxqGgoMHFcJye5h1 azDDzlewh3q5NLCnI16Tw80KrdS82esr+HecVkD4JWQGIccENLY69STdnoQeOFYPB8gUW0 9xPp0mPSdUVKVplahMCiUfLINOUib+NR/kR7IXpKZecWBafpo/h2gmisZKZu7xg+R04Bg1 ZdEOxTNWLhApBDfQbBiBxgoSIUSJ8MofPGa/XWxRGf2VJxmn0o3Tuy9ojnkUaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766029843; a=rsa-sha256; cv=none; b=wiLoGm4dKo35xKhqihcOi0fOkLUozhcsARTDjcB74Pdu3r4SbnukNibTtTNq5mBd/lzai4 pB90hF0nfjPeuTNIRmIVI8KrwoG6z1qB0xjRRWcVFLSdn1gvyKP8Z9gpuSwPKcCHO5Z/x7 tdL+JTMpPMysaZbhmgLR0gh95CMyg+cq/09DCtUHz0c51lFhNele4kcjnfoLB0evxi/qMJ Y4YAG4WFWP+SMk/9ibbBtfpezzSNV5fdok2ZAKmtuN/u25CCk31xbPxipweAhoO+FRmkdG O49e/ZLjW0g44iOjIktvhtzDdHd1uddj3+2g5RA/I3X7uzrsDLS79zVerCvhhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dWxXL5WDjz111P; Thu, 18 Dec 2025 03:50:42 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Wed, 17 Dec 2025 21:50:28 -0600 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: d3690a599586 - stable/15 - devfs: make destroy_dev() a release barrier for cdevpriv destructors runs To: Konstantin Belousov , Vladimir Kondratyev Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org References: <69431ba8.40557.13f66fa4@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/17/25 21:24, Konstantin Belousov wrote: > On Wed, Dec 17, 2025 at 09:07:52PM +0000, Vladimir Kondratyev wrote: >> The branch stable/15 has been updated by wulf: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=d3690a5995867e35d4d1dc63127343d4b0a092d6 >> >> commit d3690a5995867e35d4d1dc63127343d4b0a092d6 >> Author: Konstantin Belousov >> AuthorDate: 2025-10-23 18:37:00 +0000 >> Commit: Vladimir Kondratyev >> CommitDate: 2025-12-17 21:05:38 +0000 >> >> devfs: make destroy_dev() a release barrier for cdevpriv destructors runs >> >> Ensure that all destructors for cdevpriv finished running before >> destroy_dev() returns to the caller. Otherwise, since >> devfs_destroy_cdevpriv() removes the cdevpriv data from the list, drops >> the cdevpriv_mtx, and then starts the destructor, it is possible for >> destroy_dev() to return before destructor finished in other thread. >> >> This should allow drivers to safely remove cdev instance data that might >> be referenced by cdevpriv data. >> >> Diagnosed by: kevans >> Reviewed by: kevans, markj >> Sponsored by: The FreeBSD Foundation >> MFC after: 1 week >> Differential revision: https://reviews.freebsd.org/D53303 >> >> (cherry picked from commit 4dbe6628179d8e6bf400bfdb4bfa869bdc102a56) > > I did not merged this to 15 (or 14) because if_tun has a regressions > requiring some fixes from kevans, which were not merged. > Ah, woof- sorry, it's been busy here. I'll go ahead and merge the fix to stable/15. The relevant feature won't be merged to stable/14, so it should be safe to take it back there as well. Thanks, Kyle Evans