Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Oct 2007 16:48:00 -0700 (PDT)
From:      Jeff Roberson <jroberson@chesapeake.net>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs  fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm  vnode_pager.c
Message-ID:  <20071003164642.B615@10.0.0.1>
In-Reply-To: <200710032106.l93L65bv095725@repoman.freebsd.org>
References:  <200710032106.l93L65bv095725@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 3 Oct 2007, John Baldwin wrote:

> jhb         2007-10-03 21:06:05 UTC
>
>  FreeBSD src repository
>
>  Modified files:        (Branch: RELENG_6)
>    sys/fs/devfs         devfs_vnops.c
>    sys/fs/fifofs        fifo_vnops.c
>    sys/kern             uipc_usrreq.c vfs_vnops.c
>    sys/vm               vnode_pager.c
>  Log:
>  MFC: Always use an exclusive lock on the leaf vnode during an open() when
>  shared lookups are enabled.  This closes a few races including a race where
>  concurrent opens of a fifo could result in different v_fifoinfo structures
>  in different threads.

Long term we should really look for a better solution to this problem. 
There are a number of was to improve snapshots in ffs by fixing shared 
locking.

>
>  Revision    Changes    Path
>  1.114.2.15  +1 -0      src/sys/fs/devfs/devfs_vnops.c
>  1.113.2.20  +1 -1      src/sys/fs/fifofs/fifo_vnops.c
>  1.155.2.23  +1 -1      src/sys/kern/uipc_usrreq.c
>  1.233.2.7   +2 -2      src/sys/kern/vfs_vnops.c
>  1.221.2.9   +3 -3      src/sys/vm/vnode_pager.c
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071003164642.B615>