From owner-cvs-all@FreeBSD.ORG  Thu Sep 11 04:47:30 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F23BE16A4C2; Thu, 11 Sep 2003 04:47:29 -0700 (PDT)
Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp
	[133.80.152.80])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E6B4843FE3; Thu, 11 Sep 2003 04:47:25 -0700 (PDT)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from localhost (localhost [IPv6:::1])h8BBlIFe001242;
	Thu, 11 Sep 2003 20:47:24 +0900 (JST)
	(envelope-from nyan@jp.FreeBSD.org)
Date: Thu, 11 Sep 2003 20:46:36 +0900 (JST)
Message-Id: <20030911.204636.71188235.nyan@jp.FreeBSD.org>
To: marcel@FreeBSD.org, imp@FreeBSD.org
From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
In-Reply-To: <200309072151.h87Lp38Y087640@repoman.freebsd.org>
References: <200309072151.h87Lp38Y087640@repoman.freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/uart uart_cpu.h uart_cpu_alpha.c
 uart_cpu_amd64.c uart_cpu_i386.c uart_cpu_ia64.c uart_cpu_pc98.c
 uart_cpu_sparc64.c uart_dev_sab82532.c uart_dev_z8530.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Sep 2003 11:47:30 -0000

In article <200309072151.h87Lp38Y087640@repoman.freebsd.org>
Marcel Moolenaar <marcel@FreeBSD.org> writes:

> marcel      2003/09/07 14:51:03 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/uart         uart_cpu.h uart_cpu_alpha.c 
>                          uart_cpu_amd64.c uart_cpu_i386.c 
>                          uart_cpu_ia64.c uart_cpu_pc98.c 
>                          uart_cpu_sparc64.c uart_dev_sab82532.c 
>                          uart_dev_z8530.c 
>   Log:
>   Remove the assumption that a bus_space_handle_t is an I/O address
>   from the SAB82532 and the Z8530 hardware drivers by introducing
>   uart_cpu_busaddr(). The assumption is not true on pc98 where
>   bus_space_handle_t is a pointer to a structure.
>   The uart_cpu_busaddr() function will return the bus address
>   corresponding the tag and handle given to it by the BAS.

Don't access the inside of bus_handle directly in device driver.

BTW, bsh_base is not always the base address.

---
TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>