From owner-svn-ports-all@FreeBSD.ORG Tue Nov 26 03:53:39 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 6629125D; Tue, 26 Nov 2013 03:53:39 +0000 (UTC) Date: Tue, 26 Nov 2013 03:53:39 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files Message-ID: <20131126035339.GA43389@FreeBSD.org> References: <201311221341.rAMDfY3g002148@svn.freebsd.org> <01490d316b5dd7f01f1c843871542666@secure.marino.st> <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org> <5291C8BD.3070109@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5291C8BD.3070109@marino.st> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, owner-ports-committers@freebsd.org, Erwin Lansing , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 03:53:39 -0000 On Sun, Nov 24, 2013 at 10:37:01AM +0100, John Marino wrote: > I have attached a diff with the proposed changes covering all three > ports. It's pretty straight-forward. > > .if ${PORT_OPTIONS:MREPLACE_BASE} > -.if ${OSVERSION} >= 1000500 > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000500 Given that OSVERSION is used extensively in the tree, I'm worrying that adding these extra "${OPSYS} == FreeBSD" checks will our makefiles less readable. Wouldn't it make more sense to place this check somewhere in single place, and define whatever OSVERSION that looks reasonable when OPSYS == FreeBSD instead of patching every port? ./danfe