From owner-cvs-all Tue Jan 21 15:15:35 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81C9837B401; Tue, 21 Jan 2003 15:15:34 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BC6943F3F; Tue, 21 Jan 2003 15:15:34 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 1591CAE2F7; Tue, 21 Jan 2003 15:15:34 -0800 (PST) Date: Tue, 21 Jan 2003 15:15:34 -0800 From: Alfred Perlstein To: Jeffrey Hsu Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20030121231533.GE42333@elvis.mu.org> References: <20030121203105.GJ33821@elvis.mu.org> <0H93003IR1FCWK@mta6.snfc21.pbi.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0H93003IR1FCWK@mta6.snfc21.pbi.net> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Jeffrey Hsu [030121 13:09] wrote: > If you don't lock these operations, you could incorrectly lose the result > of an flock(), which sets different bits in the f_flag field from fcntl(). Ok. Then are you sure this is the only place where they need protection? I could have sworn I saw several other places where the file flags are updated, I'm probably wrong about it and it's just locations where they are initially set.. but since you're in the area. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message