From owner-freebsd-bugs@FreeBSD.ORG  Tue Jul 29 11:44:05 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7B4FD7B9
 for <freebsd-bugs@FreeBSD.org>; Tue, 29 Jul 2014 11:44:05 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 63BC62102
 for <freebsd-bugs@FreeBSD.org>; Tue, 29 Jul 2014 11:44:05 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s6TBi5xo026408
 for <freebsd-bugs@FreeBSD.org>; Tue, 29 Jul 2014 11:44:05 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 192238] New: rtld-elf should use powerof2(); nmaskwords must
 not be zero
Date: Tue, 29 Jul 2014 11:44:05 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: conrad.meyer@isilon.com
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-192238-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jul 2014 11:44:05 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192238

            Bug ID: 192238
           Summary: rtld-elf should use powerof2(); nmaskwords must not be
                    zero
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: conrad.meyer@isilon.com

>From DT_GNU_HASH parsing:

==========================================================
/* Number of bitmask words is required to be power of 2 */
nmw_power2 = ((nmaskwords & (nmaskwords - 1)) == 0);
obj->maskwords_bm_gnu = nmaskwords - 1;

...

obj->valid_hash_gnu = nmw_power2 && obj->nbuckets_gnu > 0 &&
    obj->buckets_gnu != NULL;
==========================================================

The nmw_power2 statement can be rewritten using the powerof2() macro from
sys/param.h:

nmw_power2 = powerof2(nmaskwords);

And valid_hash_gnu should probably include '&& nmaskwords > 0' (see underflow
in obj->maskwords_bm_gnu if nmaskwords is less than 1).

I may eventually get around to attaching a patch, but this isn't a priority for
us (just something that came up reviewing a similar change to the kernel
linker, which will end up on bugzilla sometime soon).

-- 
You are receiving this mail because:
You are the assignee for the bug.