From owner-svn-src-head@freebsd.org Wed Sep 23 14:46:22 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CF37B3FBF08 for ; Wed, 23 Sep 2020 14:46:22 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BxLbL2CH4z3RW0 for ; Wed, 23 Sep 2020 14:46:22 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1600872380; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=t/apIO1iT9lIviRabRdwAz/o3Ip5NpwJzcrOwbBopFLV/c78lbuoSPq2wQ0bV1pGtVc5tqF2CDxkX YBMUxwCzSiGTezAJN6VzHSBwhpwN9+KIs1UU41eAKDetkwdZXeTazRYcOpO0W7O9EoJEoGQc03tSUw xRPqLe90xpdl4REkHoCqfAP7NT6DDLuaeItyBDMhPXbOJXxxtnBPbaK/6CVTQtE1N2lpz0flL/k2vf DC4J80geJjjzaHNeQwb4nJspjnCbIxVBKUIDKD6NmEd7eacWKAiv3EQ5v6C6Hjr34W57/falR6JY6c 0Si+KZtlBzf6PXafXD/knVqEFLxCIug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=600esQt6bh0NDui9WMqLTaOOLP6a+Y0N+lbGIzlHNmM=; b=sH+/b3OVnWv3VUzVQk+oy/1tYBl6gm/3q60o0iY/Sd/s96A9vzNaoc2TVZNcJ6E8CaEO9wSC/DeoV L1NtvxS0nsGAZMMu9oaJg8Wn+w67qPIfLSHl+/qRqpS0rsnZFtvAjrJxVVxbJwmXFZuopHSH/ZvFYG 8qeJQ06fVmR3LJ/77B++G3WJE6Dmr9b10n+wOC44hyAFdQQAQIGhTMdi5FF/7b5mFD5NUnzkTvukku lrlmb98GbOI+DgOXJRpv61F7uK0YhRfQV72YjG53IkHKtZVRlJPrjXP2CetoFnwBeuFz/+jd75EHwA tA9Tmr6VQubeOk/icDNRiqpfdAuhXfg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=600esQt6bh0NDui9WMqLTaOOLP6a+Y0N+lbGIzlHNmM=; b=AOAo43VgrPfqyavhXLlAidDc6gf0hETqzW/vtI89YSX33DpMViQoJjphyJ4q1PVRFEUgRaYJ7W5ct 0CQz3NGHfyCIjIj2JoGD+/G55Gu5MYWj2deTjfNboKYlMgndN5Q/TGPy2589+hFKUVzl4n9GQOV2po E5OATt7ux3juYIovzIBENN88jvMJ0mpgQ4fngJRB9VmQyGPFOxxcyGPRO3c0V+bMp8Gz9a8FqYxo6h RJUhLYzVoQjOq+NbU+FTx/UFT3QPx2r+THqErIz0EJdHYjYKwJcCpQ7wYd8JvAJubM0LISTZjQPkK5 du4wAWmoSrkAkJ/UGvd2oTLYtB4PkRA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 88f7c4ae-fdab-11ea-9e11-df46ed8f892f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 88f7c4ae-fdab-11ea-9e11-df46ed8f892f; Wed, 23 Sep 2020 14:46:18 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 08NEkGYt029699; Wed, 23 Sep 2020 08:46:16 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r366042 - in head/stand: i386/zfsboot libsa From: Ian Lepore To: "Bjoern A. Zeeb" , Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 23 Sep 2020 08:46:16 -0600 In-Reply-To: <96B1694E-889E-4D04-8AB9-B689F6093FB8@lists.zabbadoz.net> References: <202009230104.08N14QIe053739@repo.freebsd.org> <96B1694E-889E-4D04-8AB9-B689F6093FB8@lists.zabbadoz.net> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BxLbL2CH4z3RW0 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 14:46:22 -0000 On Wed, 2020-09-23 at 10:44 +0000, Bjoern A. Zeeb wrote: > On 23 Sep 2020, at 1:04, Warner Losh wrote: > > > Ideally, we'd keep the cp /dev/null in the > > build as a regression test, > > Well or at least write a test case so that at least CI catches it. > > /bz It might make sense to separately test /dev/null as the source and the destination with cp. -- Ian