From nobody Fri Aug 7 14:27:09 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hGmgf18CSz6nB58 for ; Fri, 07 Aug 2026 14:27:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hGmgf0DZjz3Tq9 for ; Fri, 07 Aug 2026 14:27:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786112830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qZ/I5lknNw5mIZarXhquLbmeMlqXOdubtlyqIiT3MRQ=; b=p8XvqCrB8OOexfu9q98Un3rNUkIlWcqKYx/K6UTymdMyJWRJhIJ1aJPupqBiiMx6Ye0p26 zIXJoz/DunQK9yQTrQrvG6MNzrjydmFk/eXyIWKmfwAcNGHedi7vN7tyBhizTs4/4ZvEGs dG3UZDMFKSSz0lpdCT6WAHeqWLSNqO5QAWq24GbMHWnX84BML9/Q5WLe7RRR3hAmY3BXZs KpDOewLZAQCoPfjHyWkpQArfVQL+joTWFCEF/1LSEL23JDdzFTuNrugW0nGNDLCEL5+gz6 neWnImYHv4sUWGa/7WEP1WNVRGlCdkQfIZhcyxI1MXomTvBWJWdtMDjFnIVZiw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786112830; a=rsa-sha256; cv=none; b=OC/7whzmSmlZo5U0o0iBwZYTJYi9AQTjUumVDzV3IwcRcIlH7NCCUuBf6SD16LcK12OduF htZToSq0vhN/8H3ulcvkAXi074054ZOj1MnOAc4j1H6XPJ5haxztcGkUuk+9pXj1sIuoBH Tj00Uu5jnvwW7jtTN8oTzBNMMwnAywseJlpJ+U/MIQI9y5UAc6i5dK5aHjafEE5wemU99L 1vN44uA1lc9aQGVqyyijUIjEWTFtTvL1tl3x2sP5iBz/7u/KMFY7HB1mm351gLGFAg17v8 DDYQT4IIFPyHMHXq2n9ybIAI6+P1cmtc9sbgscuBQhmU54jxOVdBth7+eQD0cA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786112830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qZ/I5lknNw5mIZarXhquLbmeMlqXOdubtlyqIiT3MRQ=; b=NtzeB20qQ51lI4blJSZqw+6zLGAlR3UYkh0Jr2SynOC3m8iHtKD3rVAqOmmbb9/AZCJ0IC 0tPadZRioE1eCdlmEWWP0o2J00efNVMF/wuVa48snFWdIEtwelcpVQPi4Xnfq83FedmRdl OdTUg5POCy23lxUMZkp3EUluEBhFspvB0SLLT0px3NjxwDGHCNPRAFyjfO7lf9CzB00tJ/ eq+DGAgs367a1hDNTEHG8qxfA5vxJcDFah+Rlim7mYloNAGr9PHsy8eyPhSMQ7OzO0MkAV WXqTkKwXJEZZr9Pe+/gS6MgpMcG3m+cZStJ1sH1xFChIOP8ZJ9vL1Exc9dnuiw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hGmgd5mdNz19lm for ; Fri, 07 Aug 2026 14:27:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44a15 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 07 Aug 2026 14:27:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: d025b84268ec - main - ixgbe: Apply the 82599 D3 link workaround only for D3 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d025b84268ec18d55c2d3088729cf4ad7673ecac Auto-Submitted: auto-generated Date: Fri, 07 Aug 2026 14:27:09 +0000 Message-Id: <6a75eb3d.44a15.5e2f06d9@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d025b84268ec18d55c2d3088729cf4ad7673ecac commit d025b84268ec18d55c2d3088729cf4ad7673ecac Author: Kevin Bowling AuthorDate: 2026-08-05 14:33:32 +0000 Commit: Kevin Bowling CommitDate: 2026-08-07 14:26:41 +0000 ixgbe: Apply the 82599 D3 link workaround only for D3 ixgbe_stop_mac_link_on_d3_82599() implements the workaround for 82599 erratum 33. It forces incompatible auto-negotiation settings before the device enters D3, and reset clears them when returning to D0. ixgbe_if_stop() is also used for ordinary interface reconfiguration and recovery. Those paths do not enter D3 and should not program this power-management workaround. They continue to stop the adapter and disable the transmit laser. Move the call to ixgbe_setup_low_power_mode(), after ixgbe_if_stop(). This preserves the required ordering for detach, shutdown, and suspend while avoiding the D3 settings during ordinary restarts. MFC after: 2 weeks --- sys/dev/ixgbe/if_ix.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 96188ca7ef7f..5ab30a8054a9 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -3788,6 +3788,10 @@ ixgbe_setup_low_power_mode(if_ctx_t ctx) ixgbe_if_stop(ctx); } + /* Disable the 82599 link only when actually entering D3. */ + if (hw->mac.type == ixgbe_mac_82599EB) + ixgbe_stop_mac_link_on_d3_82599(hw); + return error; } /* ixgbe_setup_low_power_mode */ @@ -4758,8 +4762,6 @@ ixgbe_if_stop(if_ctx_t ctx) ixgbe_reset_hw(hw); hw->adapter_stopped = false; ixgbe_stop_adapter(hw); - if (hw->mac.type == ixgbe_mac_82599EB) - ixgbe_stop_mac_link_on_d3_82599(hw); /* Turn off the laser - noop with no optics */ ixgbe_disable_tx_laser(hw);