From owner-freebsd-hackers@FreeBSD.ORG Sat Dec 11 19:43:06 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E9EB1065696 for ; Sat, 11 Dec 2010 19:43:06 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 53A198FC08 for ; Sat, 11 Dec 2010 19:43:06 +0000 (UTC) Received: by qwj9 with SMTP id 9so4936581qwj.13 for ; Sat, 11 Dec 2010 11:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=ZvuOfXVjEXTfI31ax7RFg+PHeQQ/PnPWvoY4asJ3w1c=; b=h1OjuvqdE95DH1KYTXdJMDKTtliW7LXLLOHnIRJUX5MjaivdzfUPwkS+0flJR0m3Df AYc3r2WvbVC7776SCOqhk/8CxPdyKQKmE6rkK0Ux0I0DBiFlgXxWnPeQJGussy9jCbNX 9/78wGizqlnda6TqS8BckQy/1LpLQCvM/0p3U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=BpdKdT5M+ptYhxXCCRePA7i76G2ChkE6PxQkx7IWk6vAC7jMskD7vgL5lKpy72aA7m cYJYJ9SnUq46hrVcu8fK8LxhdvZWfArZ4Ikk809eoKGM9/3tqkJvr6XsbRHAZo3ZE6cC ZBw7apcM7tsLdcOV7IxUSYdkaa8asUYSOw7Ug= MIME-Version: 1.0 Received: by 10.229.82.10 with SMTP id z10mr2075900qck.98.1292096585521; Sat, 11 Dec 2010 11:43:05 -0800 (PST) Sender: artemb@gmail.com Received: by 10.220.177.195 with HTTP; Sat, 11 Dec 2010 11:43:05 -0800 (PST) Date: Sat, 11 Dec 2010 11:43:05 -0800 X-Google-Sender-Auth: Sr1UVIoHbHARXS36xMJg33C__rc Message-ID: From: Artem Belevich To: FreeBSD Hackers Content-Type: text/plain; charset=ISO-8859-1 Subject: syscall provider naming convention. Re: kern/152822: [patch] DTrace: syscall provider for compat/freebsd32 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Dec 2010 19:43:06 -0000 Hi, I'm tinkering with DTrace syscall provider for COMPAT_FREEBSD32 and linuxulator binaries and I wonder what would be the best way to name those providers. One option is to create separate provider for each compat variant. E.g. syscall::write/syscall32::write/syscalllnx32::write.. Another to keep provider name as syscall and use 'module' to distinguish between compat variants. E.g. syscall:native:write:/syscall:freebsd32:write:/syscall:linux32:write: I'm leaning towards using 'module' but I would appreciate hackers@ opinion on the best way to proceed. Thanks, --Artem ---------- Forwarded message ---------- From: Andriy Gapon Date: Sat, Dec 11, 2010 at 11:15 AM Subject: Re: kern/152822: [patch] DTrace: syscall provider for compat/freebsd32 To: Artem Belevich Cc: John Baldwin on 11/12/2010 21:07 Artem Belevich said the following: > I wonder if it would make more sense to keep provider as 'syscall' for > all emulations, but set 'module' part to native/compat32/linux32. > > I.e. native write syscall would be specified as syscall:native:write: > and linux32 as syscall:linux32:write: > Wildcard spec like syscall::write: would match all write variants. > > What do you think? Sounds like a very good idea to me! Could you please run it by hackers@ just to see what other people think? Thanks. -- Andriy Gapon