From owner-svn-src-head@FreeBSD.ORG Thu May 5 14:13:16 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B940106576A; Thu, 5 May 2011 14:13:16 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward3.mail.yandex.net (forward3.mail.yandex.net [77.88.46.8]) by mx1.freebsd.org (Postfix) with ESMTP id D0E808FC1E; Thu, 5 May 2011 14:13:14 +0000 (UTC) Received: from smtp3.mail.yandex.net (smtp3.mail.yandex.net [77.88.46.103]) by forward3.mail.yandex.net (Yandex) with ESMTP id F0177B42EF7; Thu, 5 May 2011 18:02:11 +0400 (MSD) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1304604132; bh=z+KZiG7g9ZOaP/oSBepFHT1ck8+woazHvvwEBWQX3rg=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=KNST2gkAp+cTKk4z7fnQqyoiBHHmo4+iBb6cekiKR0sJUYYk3Hf2RjUeTaP39K9OP YBPnbeLJRSmcf6k061MW5R0xmSR/d7dzfhYe1zdwEuH3vIlLcLwaqFo7WiYhCqQ4jd SKefz7i7au4myAzcYZ9/TvVaZhskBxx1nvJo3fiQ= Received: from [178.141.5.18] (dynamic-178-141-5-18.kirov.comstar-r.ru [178.141.5.18]) by smtp3.mail.yandex.net (Yandex) with ESMTPSA id 92AB96980076; Thu, 5 May 2011 18:02:11 +0400 (MSD) Message-ID: <4DC2ADDD.6040409@yandex.ru> Date: Thu, 05 May 2011 18:02:05 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201105041806.p44I6edT061463@svn.freebsd.org> <20110505131242.GC14661@garage.freebsd.pl> In-Reply-To: <20110505131242.GC14661@garage.freebsd.pl> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFD4604761B4CDB2D5D3E7B29" X-Yandex-Spam: 1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221449 - head/sys/geom/journal X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 14:13:16 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFD4604761B4CDB2D5D3E7B29 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 05.05.2011 17:12, Pawel Jakub Dawidek wrote: >> New Revision: 221449 >> URL: http://svn.freebsd.org/changeset/base/221449 >> >> Log: >> Removed KASSERT, g_new_providerf() can not fail. >=20 > Well, the assertion was there to prepare us for times when > g_new_providerf() will be able to fail. I was suspecting we might want > to make g_new_providerf() to fail when the given name is already in use= =2E I think such change will break all code we have now :) But now when it can not fail, KASSERT could slightly confuse those who read code as example. > In such case we use to create two identical entries in /dev/, not sure > what we do now (panic?). geom_dev prints out an error message. --=20 WBR, Andrey V. Elsukov --------------enigFD4604761B4CDB2D5D3E7B29 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJNwq3dAAoJEAHF6gQQyKF6nF4H/RtUjvQz+7UzpR1s2u+uKq1w D9K/jxbJUY4WWErMPnbVOWH5jp1MsKQcuww1Vjj1SsI8SLQ+3sL7ErBSzvUwcMnq wiJnW3fwKgCokpBNaEmHs4Iu+jo67JS/R3cYwvYsXHG/e9fCSJxZKLh3ENl4peSX taUoxKdGWCjhPAKqabf6oydPWCVUXj39nLNdeleLd44jM5eWpFPhKvRrYWlcJ/7V 5lm2edEppzX5DOL1ZUuBJZVhk9oXcNfqtffwiLu70xMWt2QtNntcoq1kcn41yvNq YJvCrnxYcDv5/yUIXgYyL1t/7ypSY5u2w90E1/L2ZBX6ORLD8RWIIKtXSgkX43Q= =7ydh -----END PGP SIGNATURE----- --------------enigFD4604761B4CDB2D5D3E7B29--