Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Dec 2024 11:59:14 GMT
From:      Hiroki Tagato <tagattie@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 6dfe35ea0748 - main - editors/vscode: remove USE_LDCONFIG and add BUNDLE_LIBS
Message-ID:  <202412041159.4B4BxEEG030441@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by tagattie:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6dfe35ea074854a8b64b8deba730a8718e8c16ef

commit 6dfe35ea074854a8b64b8deba730a8718e8c16ef
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2024-12-04 11:57:05 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2024-12-04 11:59:05 +0000

    editors/vscode: remove USE_LDCONFIG and add BUNDLE_LIBS
    
    Shared libraries installed along with vscode are for internal use and
    not intended for public consumption.
    
    Remove USE_LDCONFIG so as not to add the shared library directory to
    search paths. Add BUNDLE_LIBS so that pkg(8) does not pick the shared
    libraries up for packaging.
    
    Bump port revision for package change.
    
    Related GitHub Issue: https://github.com/freebsd/pkg/issues/2368
    
    Reported by     Vlad Biley <bileslav@gmail.com>
---
 editors/vscode/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/editors/vscode/Makefile b/editors/vscode/Makefile
index 45db5c9561dc..e309b2ee0795 100644
--- a/editors/vscode/Makefile
+++ b/editors/vscode/Makefile
@@ -1,6 +1,6 @@
 PORTNAME=	vscode
 DISTVERSION=	1.95.3
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	editors
 MASTER_SITES=	https://github.com/tagattie/FreeBSD-VSCode/releases/download/${DISTVERSION}/:node_modules
 DISTFILES=	vscode-node-modules-${DISTVERSION}${EXTRACT_SUFX}:node_modules \
@@ -80,13 +80,12 @@ USE_XORG=	x11 xcb xcomposite xcursor xdamage xext xfixes xi xkbfile \
 USE_GL=		gbm gl glesv2
 USE_GNOME=	atk cairo pango gdkpixbuf2 gtk30 libxml2 libxslt
 
-USE_LDCONFIG=	${DATADIR}
-
 SHEBANG_REGEX=	./(extensions|node_modules|resources|scripts|src)/.*\.sh$$
 PATHFIX_FILES=	src/vs/workbench/contrib/debug/node/terminals.ts
 
 DATADIR=	${PREFIX}/share/code-oss
 TMPDIR=		${WRKDIR}
+BUNDLE_LIBS=	yes
 
 MAKE_ENV+=	BUILD_SOURCEVERSION=${SOURCE_COMMIT_HASH}
 # Don't download electron binary distribution on electron node_modules installation



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202412041159.4B4BxEEG030441>