From owner-cvs-all Thu Jan 10 10: 7:38 2002 Delivered-To: cvs-all@freebsd.org Received: from patrocles.silby.com (d182.as13.nwbl0.wi.voyager.net [169.207.136.248]) by hub.freebsd.org (Postfix) with ESMTP id 2181A37B416; Thu, 10 Jan 2002 10:07:32 -0800 (PST) Received: from localhost (silby@localhost) by patrocles.silby.com (8.11.6/8.11.6) with ESMTP id g0ACAM407490; Thu, 10 Jan 2002 12:10:22 GMT (envelope-from silby@silby.com) X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs Date: Thu, 10 Jan 2002 12:10:22 +0000 (GMT) From: Mike Silbersack To: Ian Dowse Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c In-Reply-To: <200201100129.aa00865@salmon.maths.tcd.ie> Message-ID: <20020110120927.T7162-100000@patrocles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 10 Jan 2002, Ian Dowse wrote: > In message <200201091714.aa02189@salmon.maths.tcd.ie>, Ian Dowse writes: > >In fact, > >a much better approach would be to change the code so that it reads > >large blocks in fixed-sized chunks. I'll see if that can be done > >without too much additional code-bloat. > > This turned out to be relatively easy to do and it actually reduces > the size of boot2 by 92 bytes, mainly because the simple malloc() > function is no longer needed. It uses 4k buffers regardless of the > filesystem block size (4k is the minumum ffs block size), so it > should work with any block size. > > Ian Wow, neat. I'd review it for you, but I'm not up on my FSes. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message