From owner-p4-projects Tue Jul 16 6:45:18 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 511B537B405; Tue, 16 Jul 2002 06:45:14 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 7BD5237B400; Tue, 16 Jul 2002 06:45:13 -0700 (PDT) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g6GDi8678281; Tue, 16 Jul 2002 09:44:08 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200207161344.g6GDi8678281@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Robert Watson , Perforce Change Reviews Subject: Re: PERFORCE change 14125 for review In-Reply-To: Your message of "Mon, 15 Jul 2002 12:36:39 EDT." <200207151636.g6FGadD69438@green.bikeshed.org> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 16 Jul 2002 09:44:08 -0400 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Brian F. Feldman" wrote: > Robert Watson wrote: > > We probably need to sit down with the source, because I think this still > > isn't right. mac_update_vnode_from_externalized() is intended to take a > > fully filled out extmac from the extended attribute, and initialize a > > vnode label from it. You've changed the code flow so that you call it > > even when extmac doesn't contain any valid data, which is simply > > incorrect. Probably what we need is a new entry point intended > > specifically to handle policies that manage the loading of the > > externalized form themselves. Something on the order of: > > > > mac_update_vnode(vp); > > I suppose adding that hook probably will be a solution, if not an elegant > one. I'd rather it just not call it for policies that have no data but a > reserved data slow. slot As in, policies that will not externalize/internalize directly with the MAC framework support, but rather their own. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message