From owner-svn-src-all@FreeBSD.ORG Wed Jun 13 11:15:05 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 83419106566C; Wed, 13 Jun 2012 11:15:05 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 2962A8FC1B; Wed, 13 Jun 2012 11:15:05 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 1C503553; Wed, 13 Jun 2012 13:15:04 +0200 (CEST) Date: Wed, 13 Jun 2012 13:13:09 +0200 From: Pawel Jakub Dawidek To: Mateusz Guzik Message-ID: <20120613111309.GE1386@garage.freebsd.pl> References: <4FD6FD39.5090800@gmail.com> <20120612104749.GB20749@dft-labs.eu> <20120612114335.GA1372@garage.freebsd.pl> <20120612134950.GC20749@dft-labs.eu> <20120612160128.GA1429@garage.freebsd.pl> <20120612191828.GD20749@dft-labs.eu> <20120612214400.GB1429@garage.freebsd.pl> <20120613093807.GA3893@dft-labs.eu> <20120613102900.GD1386@garage.freebsd.pl> <20120613105344.GB3893@dft-labs.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J5MfuwkIyy7RmF4Q" Content-Disposition: inline In-Reply-To: <20120613105344.GB3893@dft-labs.eu> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org Subject: Re: svn commit: r236935 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2012 11:15:05 -0000 --J5MfuwkIyy7RmF4Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch >=20 > David reported that previous version of the patch fixed panic he was > experiencing, so I consider the patch tested. Looks good, one (hopefully last) minor nit. I'd change this comment: * Search the bitmap for a free descriptor starting at minfd. If none * is found, try to grow the file table. To something like this: * Search the bitmap for a free descriptor starting at minfd. * If none is found, grow the file table. 'try' is a bit misleading for my taste, as it suggest that growing the file table might fail, I think. That's all from me:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --J5MfuwkIyy7RmF4Q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/YdcQACgkQForvXbEpPzRz9ACdGv4lUkw6NG7Ec6wDW9dKdDmZ vGIAoJY1XtySkVRuV5bZCxLwKvd2HZ8m =+RpD -----END PGP SIGNATURE----- --J5MfuwkIyy7RmF4Q--