From owner-freebsd-current@FreeBSD.ORG Tue Sep 28 07:18:10 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3102316A4CE for ; Tue, 28 Sep 2004 07:18:10 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9759C43D49 for ; Tue, 28 Sep 2004 07:18:06 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (oak.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i8S7Hwsf044091; Tue, 28 Sep 2004 10:17:58 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 76295-04; Tue, 28 Sep 2004 10:17:57 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i8S7HvYm044088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Sep 2004 10:17:57 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i8S7Hwqi015170; Tue, 28 Sep 2004 10:17:58 +0300 (EEST) (envelope-from ru) Date: Tue, 28 Sep 2004 10:17:58 +0300 From: Ruslan Ermilov To: Xin LI Message-ID: <20040928071758.GB14942@ip.net.ua> References: <20040927224353.845381B217@merlin.emma.line.org> <20040928043351.GA2400@frontfree.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <20040928043351.GA2400@frontfree.net> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: Matthias Andree cc: current@FreeBSD.org Subject: Re: bin/72138: libc.so.5 isn't installed in a safe way X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2004 07:18:10 -0000 --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Xin and Matthias, On Tue, Sep 28, 2004 at 12:33:51PM +0800, Xin LI wrote: > (-CURRENT is cc'ed for a boarder review) >=20 > I fell like this idea, and here is the patch for review: >=20 > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /r/ncvs/src/lib/libc/Makefile,v > retrieving revision 1.52 > diff -u -r1.52 Makefile > --- Makefile 14 May 2004 12:04:29 -0000 1.52 > +++ Makefile 28 Sep 2004 04:30:26 -0000 > @@ -16,6 +16,7 @@ > CFLAGS+=3D-I${.CURDIR}/include -I${.CURDIR}/../../include > CFLAGS+=3D-I${.CURDIR}/${MACHINE_ARCH} > CLEANFILES+=3Dtags > +SHLINSTALLFLAGS+=3D -S > INSTALL_PIC_ARCHIVE=3D yes > PRECIOUSLIB=3D yes > =20 I like the idea so much, that I suggest this instead: %%% Index: bsd.lib.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/share/mk/bsd.lib.mk,v retrieving revision 1.160 diff -u -r1.160 bsd.lib.mk --- bsd.lib.mk 7 May 2004 09:58:36 -0000 1.160 +++ bsd.lib.mk 28 Sep 2004 07:13:18 -0000 @@ -187,9 +187,12 @@ =20 .if !target(install) =20 -.if defined(PRECIOUSLIB) && !defined(NOFSCHG) +.if defined(PRECIOUSLIB) +.if !defined(NOFSCHG) SHLINSTALLFLAGS+=3D -fschg .endif +SHLINSTALLFLAGS+=3D -S +.endif =20 _INSTALLFLAGS:=3D ${INSTALLFLAGS} .for ie in ${INSTALLFLAGS_EDIT} %%% If you like it, please feel free to commit. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBWRAlqRfpzJluFF4RAqhAAKCdYvkRuzjVqVPlZAfCPcnR8YPXlACePdLi waNgkgCAjigy90hmt9SUqM0= =5sI4 -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--