From owner-dev-commits-doc-all@freebsd.org Thu Jun 17 16:39:06 2021 Return-Path: Delivered-To: dev-commits-doc-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59817656082 for ; Thu, 17 Jun 2021 16:39:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G5SSB21zMz3Jjv; Thu, 17 Jun 2021 16:39:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2E71312F00; Thu, 17 Jun 2021 16:39:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 15HGd6hH043152; Thu, 17 Jun 2021 16:39:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 15HGd6ue043151; Thu, 17 Jun 2021 16:39:06 GMT (envelope-from git) Date: Thu, 17 Jun 2021 16:39:06 GMT Message-Id: <202106171639.15HGd6ue043151@gitrepo.freebsd.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org From: Warner Losh Subject: git: b7385189ef - main - committers-guide: Strongly suggest careful review of all pull requests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: doc X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b7385189ef01de0a37ad5490ce14f3c85bab1af2 Auto-Submitted: auto-generated X-BeenThere: dev-commits-doc-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the doc repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 16:39:06 -0000 The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/doc/commit/?id=b7385189ef01de0a37ad5490ce14f3c85bab1af2 commit b7385189ef01de0a37ad5490ce14f3c85bab1af2 Author: Warner Losh AuthorDate: 2021-06-16 22:33:08 +0000 Commit: Warner Losh CommitDate: 2021-06-17 16:38:19 +0000 committers-guide: Strongly suggest careful review of all pull requests Pull requests should be treated with extreme caution and be carefully reviewed. Add this advice. Reviewed by: allanjude,bcr Sponsored by: Netflix Differential Revsion: https://reviews.freebsd.org/D30794 --- documentation/content/en/articles/committers-guide/_index.adoc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index fffc6ef128..1d1d3df923 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -2329,15 +2329,21 @@ However, when there's multiple commits, especially when minor adjustments are ne Briefly, these commands create a branch; cherry-picks the changes from the pull request; tests it; adjusts the commit messages; and fast forward merges it back to `main`. The PR number is `$PR` below. When adjusting the message, add `Pull Request: https://github.com/freebsd-src/pull/$PR`. +All pull requests committed to the FreeBSD repository should be reviewed by at least one person. +This need not be the person committing it, but in that case the person committing it should trust the other reviewers competence to review the commit. +Committers that do a code review of pull requests before pushing them into the repo should add a `Reviewed by:` line to the commit, because in this case it is not implicit. +Add anybody that reviews and approves the commit on github to `Reviewed by:` as well. +As always, care should be taken to ensure the change does what it is supposed to, and that no malicious code is present. [NOTE] ====== In addition, please check to make sure that the pull request author name is not anonymous. -Github's web interface generates names like: +Github's web editing interface generates names like: [source,shell] .... Author: github-user <38923459+github-user@users.noreply.github.com> .... A polite request to the author for a better name and/or email should be made. +Extra care should be taken to ensure no style issue or malicious code is introduced. ====== [source,shell]