Date: Wed, 22 Jul 2015 12:23:13 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pietro Cerutti <gahr@gahr.ch> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r392666 - head/audio/libgroove Message-ID: <20150722122313.GA50653@FreeBSD.org> In-Reply-To: <d4dfd69de717fd8d4e5ef472408644e1@gahr.ch> References: <201507220652.t6M6qVFO094263@repo.freebsd.org> <d4dfd69de717fd8d4e5ef472408644e1@gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 22, 2015 at 01:49:37PM +0200, Pietro Cerutti wrote: > > @@ -1,29 +1,29 @@ > > -# Created by: gahr > > +# Created by: Pietro Cerutti <gahr@FreeBSD.org> > > I would have appreciated you notifying me of such change. > Is this modification really needed? It's obviously not *really* needed as it touches Makefile header, thus being non-functional. On on the other hand, we're not forbidding non-functional changes, right? :) I try to keep these tags consistent across committers and people without freefall login for a number of reasons, and first + last names with and email in angle brackets makes it look neat and standard. It's a bit sad that we did not advertise this form through the PHB since the beginning. > Are you going to change all similar occurrences in the ports tree? I won't convert them in bulk, most certainly. I do expand them when I notice one (and was not asked to leave that/those particular one alone). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150722122313.GA50653>