From owner-svn-src-head@freebsd.org Sat Dec 30 15:28:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76C95E8ACAB; Sat, 30 Dec 2017 15:28:01 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 543B580413; Sat, 30 Dec 2017 15:28:00 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vBUFRxaA076352; Sat, 30 Dec 2017 07:27:59 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vBUFRxtr076351; Sat, 30 Dec 2017 07:27:59 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201712301527.vBUFRxtr076351@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r327379 - head/sys/isa In-Reply-To: <201712300816.vBU8GVFu007528@repo.freebsd.org> To: Warner Losh Date: Sat, 30 Dec 2017 07:27:59 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Dec 2017 15:28:01 -0000 [ Charset UTF-8 unsupported, converting... ] > Author: imp > Date: Sat Dec 30 08:16:31 2017 > New Revision: 327379 > URL: https://svnweb.freebsd.org/changeset/base/327379 > > Log: > On further testing on actual machines with this hardware, we should > only warn for devices that are attached. Add missing \n. > > Modified: > head/sys/isa/isa_common.c > > Modified: head/sys/isa/isa_common.c > ============================================================================== > --- head/sys/isa/isa_common.c Sat Dec 30 07:59:32 2017 (r327378) > +++ head/sys/isa/isa_common.c Sat Dec 30 08:16:31 2017 (r327379) > @@ -573,9 +573,10 @@ isa_probe_children(device_t dev) > > err = device_probe_and_attach(child); > if (err == 0 && idev->id_vendorid == 0 && > - strcmp(kern_ident, "GENERIC") == 0) > + strcmp(kern_ident, "GENERIC") == 0 && > + device_is_attached(child)) > device_printf(child, > - "non-PNP ISA device will be removed from GENERIC in FreeBSD 12."); > + "non-PNP ISA device will be removed from GENERIC in FreeBSD 12.\n"); Hat: RE Do you plan to give this notice in 11.x? (Technically a bit late, it should of been in 11.0). As giving it in 12.0 wont happen if you remove it in 12. Ie, as you have stated you want to remove this before we branch 12.0, if you do that this notice well never be seen by the users. Or well, they might get the notice, but the drivers well have already been removed. Or do you want to give notice in 12.* that it is being removed in 13.0. And that is not supporting these for 10 years, as 12.x should be EOL in a bit over 5 years from now if we cut in early 2018 which I believe to be the current target. > } > > /* > > -- Rod Grimes rgrimes@freebsd.org