Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Apr 2001 04:48:21 +0900
From:      "Akinori MUSHA" <knu@iDaemons.org>
To:        ports@FreeBSD.org, portmgr@FreeBSD.org
Subject:   Re: call for review: a patch against bsd.port.mk
Message-ID:  <86zod07qm2.wl@archon.local.idaemons.org>
In-Reply-To: <861yqc95z2.wl@archon.local.idaemons.org>
References:  <861yqc95z2.wl@archon.local.idaemons.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Oops,

At Sun, 29 Apr 2001 04:31:13 +0900,
I wrote:
> @@ -1732,6 +1754,10 @@
>  			*.Z|*.gz) \
>  				${GZCAT} $$i | ${PATCH} ${PATCH_DIST_ARGS}; \
>  				;; \
> +			*.bz2) \

> +				pwd ; echo ${BZCAT} $$i ! ${PATCH} ${PATCH_DIST_ARGS}; \

This line was bogus, just a debug print.  Please ignore.

> +				${BZCAT} $$i | ${PATCH} ${PATCH_DIST_ARGS}; \
> +				;; \
>  			*) \
>  				${PATCH} ${PATCH_DIST_ARGS} < $$i; \
>  				;; \


By the way,

> 2. Add a bunch of command macros for convenience, mostly from NetBSD
> pkgsrc.

Some commands such as ${ECHO}, ${TRUE}, and ${FALSE} can probably be
made to point to shell builtin commands instead of /bin/* or
/usr/bin/* ones to reduce overheads. (Perhaps some depends on SHELL,
though)

Now, what about defaulting ECHO=echo, TRUE=true, FALSE=false like
NetBSD pkgsrc does, perhaps conditionally on SHELL?

-- 
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"Freeze this moment a little bit longer, make each impression
  a little bit stronger..  Experience slips away -- Time stand still"

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zod07qm2.wl>