From owner-svn-src-all@freebsd.org Tue Nov 10 16:07:31 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B088A2B889 for ; Tue, 10 Nov 2015 16:07:31 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6F741DAF for ; Tue, 10 Nov 2015 16:07:30 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lfs39 with SMTP id 39so701362lfs.3 for ; Tue, 10 Nov 2015 08:07:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=WiopZ85Xf1/fpwM9XbLw5axSvlJK4AlO651CWwtXdGA=; b=ZnzBe80JrI0yBkXUkkWv1Yi2vkm4xlbchoKyZrny8xW4krNO4is6ni5KJ3p/UtV5Aa RnJpIGkuAdrlNXZt3mHIDg1h5rx+guOuenIu+zO863bMvasUZ6ggQ7eO/uenbMq1vhG1 IIRp3SQsMizQPolEV7QYkASjj1Eo6BWzObhlGE1fJQR4oohcHdfSj7YeUuuJefxdCGsc pgE0t0qKGo0hLXFQQwmbWwkcd/x1l4npEqQneOyKuVZRcTxyItFMzAP48HDw4Io+15ux svrhDhoblRmTdxs44zAXwQgfGgHsfFAsNJjr7NIeajyIu+jd8NKXhyD5SybLUF5NgJdU 0R9Q== X-Gm-Message-State: ALoCoQn+ezb4heYfxeDr9GSVAUry2Gbx5C7pu8B46QS8qOeX2IcCxOv242oc0AgMg+c62qKpIfw2 X-Received: by 10.25.170.11 with SMTP id t11mr1976559lfe.20.1447171648290; Tue, 10 Nov 2015 08:07:28 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id ai8sm641446lbd.11.2015.11.10.08.07.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:07:27 -0800 (PST) Subject: Re: svn commit: r290637 - head/lib/libc/locale To: Baptiste Daroussin , tcltk@FreeBSD.org References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov X-Enigmail-Draft-Status: N1110 Message-ID: <5642163E.1050405@freebsd.org> Date: Tue, 10 Nov 2015 19:07:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151110133615.GL10134@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:07:31 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.11.2015 16:36, Baptiste Daroussin wrote: > On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: >> On 10.11.2015 16:04, Baptiste Daroussin wrote: >>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: >>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: >>>>> Author: bapt >>>>> Date: Tue Nov 10 08:11:27 2015 >>>>> New Revision: 290637 >>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 >>>>> >>>>> Log: >>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales >>>>> as it used to be in previous version of the locales. Returning >>>>> "POSIX" has too many fallouts. >>>> >>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be >>>> different with real US-ASCII. It is what glibc returns for C/POSIX >>>> locale and most ports expected, being linux-oriented. >>>> >>> I thought about it, but in the end it is probably safer for now that = nl_langinfo >>> return US-ASCII as it did in the past, to reduce breakage with FreeBS= D only code >>> that maybe be existing ou there. >> >> All FreeBSD code I know never check locale this way. IMHO probability = of >> potential danger to meet some linux-oriented port with this check is >> much much higher than to meet similar FreeBSD only code in the wild. I= n >> any case, changing collate order from A-Za-z to aA-zZ we do just now >> have much higher probability to break unknown FreeBSD only code, so on= e >> breaking change can go with other one together. >> > That is true, except that the new collation thing is invalidated as soo= n as you > set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a worka= round while > changing the return value of nl_langinfo() is not workaroundable. Well, forget my improper comparison with collate and see this bug in action right now, in our port tcl8.6.4/unix/tclUnixInit.c: See localeTable and comment above it, there is internal "ansi_x3.4-1968" (i.e. POSIX locale), internal "ascii" and even no alias for our "us-ascii" at all. It gets info through nl_langinfo(CODESET), lowercased. I.e. not using "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essential than hypothetical private FreeBSD only code no one see. --=20 http://ache.vniz.net/ --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWQhY+AAoJEKUckv0MjfbKqXUH/0uiAxp2+xqp1Z1B8p5JlqBT YRHkQyGWiJRYaw+HceXwhfGFe3LhIpPAgLaND0H7AIPOFjKP5B9kDr4OKwY6CjFI 2ogBIlkJkLJvSshS2DzSICiGrsAbs2hAGx7FHIODtaSEx6jSrlbDX8a/sBETopeT uT0Z95hnBWfut5eEQuymQnrAS0rCr2IcJECuzFInZ57KJ0RmruLdSZtNO/VSCIEU 99YDp5MAMk9/YdQvS9nAWF/mlu/nQSEN0dHSXWt0q507OovOkFtPvihIYUCMFZxe BkbNwYXCSMJ5q4W9FvklGHXz6qJkkOKiwh0EQYklXeMaEBfdbRPItKL/SchFyYg= =mbgi -----END PGP SIGNATURE----- --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN--