Date: Sat, 27 Aug 2011 23:03:13 +0400 From: Igor Soumenkov <2igosha@gmail.com> To: rakuco@FreeBSD.org Cc: Igor Soumenkov <2igosha@gmail.com>, freebsd-ports@FreeBSD.org Subject: Re: How to escalate? ports/159276 - cmake Message-ID: <4E593F71.1000401@soumenkov.com> In-Reply-To: <4E592A74.8020605@soumenkov.com> References: <4E58A6AA.4060805@soumenkov.com> <4E58F04F.7030008@cassiba.com> <4E58F3B4.8060706@soumenkov.com> <CADLo839m%2BgkmG5Y=MYX8sHjdD20hO_GdP-7%2Bn-Hpjr9O7unAcA@mail.gmail.com> <4E592A74.8020605@soumenkov.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------020901000509070103060100 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 27.08.2011 21:33, Igor Soumenkov wrote: > >> Igor Soumenkov <2igosha at gmail.com <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>>; writes: >> >> >/ Unfortunately, one of them ( Max Brazhnikov (makc@) ) is the committer I >> />/ am writing about. >> />/ And I CC:ed the kde@ mailing list, but got reply only from Max. I quoted >> />/ it here ("we can't just remove it...") - he is not going to fix it, and >> />/ he is not replying to my e-mails anymore. >> />/ That is why I am trying to find someone who can help with this situation. >> / >> I think there is some misunderstanding here. makc@ has probably been >> busy with other stuff, as he has not been very active in other threads >> as well, so we (as in kde@) are not ignoring you, and I would read "we >> can't just remove it" more as "you are welcome to help us find a >> solution" than "we do not care if it does not work in your case". >> >> There have been other threads (and discussions in #kde-freebsd on >> Freenode) about the issue, but I don't think I was involved in most of >> them. Please take a look at the mailing list archives (as you probably >> have already seen the original PR) and help us find a solution which can >> make all of us happy. > I am happy to hear that things are not as bad as I expected :-) > I will follow your advice and will try to find discussions related to > the original PR. > AFAIU, the patch was created while solving ports/150363 (dates correlate). The same effect can be achieved by specifying CMAKE_C(XX)_FLAGS_{RELEASE,DEBUG} in command line. So, I suggest removing the patch from ports/devel/cmake/files/patch-Modules_Compiler_GNU.cmake and patching ports/Mk/bsd.cmake.mk instead (attached). After applying this patch system C(XX)FLAGS will be propagated for Release and Debug build configurations. Please correct me if there are more issues caused by cmake's C(XX)FLAGS or if the patch doesn't work as expected (I've tested it locally on several ports, CFLAGS were passed correctly). Thanks. Igor. --------------020901000509070103060100 Content-Type: text/plain; name="patch.bsd.cmake.mk.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patch.bsd.cmake.mk.txt" --- ports/Mk/bsd.cmake.mk.original 2011-08-27 21:47:00.000000000 +0400 +++ ports/Mk/bsd.cmake.mk 2011-08-27 22:43:46.000000000 +0400 @@ -53,7 +53,11 @@ CMAKE_ARGS+= -DCMAKE_C_COMPILER:STRING="${CC}" \ -DCMAKE_CXX_COMPILER:STRING="${CXX}" \ -DCMAKE_C_FLAGS:STRING="${CFLAGS}" \ + -DCMAKE_C_FLAGS_DEBUG:STRING="${CFLAGS}" \ + -DCMAKE_C_FLAGS_RELEASE:STRING="${CFLAGS}" \ -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}" \ + -DCMAKE_CXX_FLAGS_DEBUG:STRING="${CXXFLAGS}" \ + -DCMAKE_CXX_FLAGS_RELEASE:STRING="${CXXFLAGS}" \ -DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \ -DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" \ -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES --------------020901000509070103060100--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E593F71.1000401>