From owner-freebsd-current@FreeBSD.ORG Thu Jun 3 07:03:00 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E75D16A4CE for ; Thu, 3 Jun 2004 07:03:00 -0700 (PDT) Received: from mail-in-05.arcor-online.net (mail-in-05.arcor-online.net [151.189.21.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id C04DB43D46 for ; Thu, 3 Jun 2004 07:02:59 -0700 (PDT) (envelope-from naddy@mips.inka.de) Received: from kemoauc.mips.inka.de (dsl-213-023-058-089.arcor-ip.net [213.23.58.89]) by mail-in-05.arcor-online.net (Postfix) with ESMTP id DDB27AB6A05; Thu, 3 Jun 2004 16:02:47 +0200 (CEST) Received: from kemoauc.mips.inka.de (localhost [127.0.0.1]) i53E2lJi084002; Thu, 3 Jun 2004 16:02:47 +0200 (CEST) (envelope-from naddy@kemoauc.mips.inka.de) Received: (from naddy@localhost) by kemoauc.mips.inka.de (8.12.11/8.12.11/Submit) id i53E2jUl084001; Thu, 3 Jun 2004 16:02:45 +0200 (CEST) (envelope-from naddy) Date: Thu, 3 Jun 2004 16:02:45 +0200 From: Christian Weisgerber To: Andrew Thompson Message-ID: <20040603140245.GA79548@kemoauc.mips.inka.de> References: <20040603012501.GA5035@thingy.tbd.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040603012501.GA5035@thingy.tbd.co.nz> User-Agent: Mutt/1.4.2.1i cc: freebsd-current@FreeBSD.org Subject: Re: Network driver jumbo patch (affects multicast) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2004 14:03:00 -0000 Andrew Thompson: > You have removed the following comment from if_xl.c. The two notes are > still relevant, should they stay? > > - * Note: the 3c905B currently only supports a 64-bit hash table, > - * which means we really only need 6 bits, but the manual indicates > - * that future chip revisions will have a 256-bit hash table, > - * hence the routine is set up to calculate 8 bits of position > - * info in case we need it some day. > - * Note II, The Sequel: _CURRENT_ versions of the 3c905B have a > - * 256 bit hash table. This means we have to use all 8 bits regardless. > - * On older cards, the upper 2 bits will be ignored. Grrrr.... I think it's just rambling. I mean, it says that (1) the specs tell us to use the lower eight bits of the hash, and (2) that's what the driver does. That some early production run 3C905Bs (just how many years ago?) ignored the two upper bits is irrelevant trivia. NetBSD also uses the lower eight bits. Now, a more interesting question is why OpenBSD uses the upper six bits... -- Christian "naddy" Weisgerber naddy@mips.inka.de