From nobody Thu Aug 6 01:42:05 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFqlL35SWz6nZDP for ; Thu, 06 Aug 2026 01:42:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFqlK5qVmz3Tk3 for ; Thu, 06 Aug 2026 01:42:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785980525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FeGFH4N6/0MiRVJfDmDBHk8D98rSnLo3ntp1oCJOhBE=; b=EVdr+kWOuK0w2HbGo0LdAmtm1fMdKzyQqpHP/hDcGN5Qru/MpjRx4eYufSklreOPoyMMTR lhBpu6R5v1y+QNTrf9gM8arPN5pfODCXPozfGLNppraheZGfx5JOmakCcnKZCyO9ttR8LU Mn0j7gAV8JU2nT2B/DoUQUw1t5J40A29qmI4l4uwVu13lN5wheZ+eCwIxcyw8c8Fi+eYk7 ZR/4hh52YAqTpIhVa2kdV6McIT4OcCyWb3rqHoXdQT65bAH/eoOHie3XGxujqCvCUQzuST 6rGQcJbbvQ0CAmdkfpId9SS2cX5c9e4bBvCoUXpukeTsxN/7U/r2pppHk/Gz/A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785980525; a=rsa-sha256; cv=none; b=K26Cw417+XGAQlljL78IE/Alk5fQOHFO3EKP7xNfk/P3td9z0Dvx/MTPkMg0uY9dMeEX5O mkqHdtOJW1+Xx75h+afHYLhRZApdN0C0j49bYnch20Knh11qp9hGboepsoVEQAgreTulxv IfYlfOctvBuT9HlmlKiU1AhlBnQ809lxcPujRmAo9UcZwiLNq1XEgGASKfwMgPECQHfOFM HaEqwrywFYTzDC0afKkmynL868SVsDFUQ6/Oewn3vbuu9AyBdXoArQ+6WlWaqqVFDKCP1M ourWc/8szsAh0CLlOgz3ciMLH7iOpB9vgCeNVPwLKsaXvvtvfHGbQiy6f5cW6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785980525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FeGFH4N6/0MiRVJfDmDBHk8D98rSnLo3ntp1oCJOhBE=; b=gRvFIAE1qrVWaqu49NdgUDjUSk0ZdMx1UbTdBT8B5z9Y22jXFbrJu6xeuzjvmuk1ayFlBx +GntCg6aeGVuP+Im2kOMYOuU77Y4QtVRIy6RIczf/rFwqFc9bu8YJJNDJ94FmJSiAj4NR+ p0XGMvYnKou8YefQSgx1fha+3KYkIkFHghWqPNd9Q7kXXMhDhWIMnOIRVZF0NM6mGTuKIA 6PdTMqoO4vfoao96otZ3yXXTz866oiZMMHI4I4LsfsQ34TznKeRa1mY1chutu+r57cOM84 te6NElIEngPWNGxXVSzJZym57zbjEeejedrnlih8utM4tO3dXBEADliTO0Vb6w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFqlK47FYz10W4 for ; Thu, 06 Aug 2026 01:42:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a794 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 06 Aug 2026 01:42:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Li-Wen Hsu Subject: git: e6b49d71f259 - stable/15 - libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: lwhsu X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e6b49d71f25932b043575535cbe35c917bd71768 Auto-Submitted: auto-generated Date: Thu, 06 Aug 2026 01:42:05 +0000 Message-Id: <6a73e66d.3a794.9634f37@gitrepo.freebsd.org> The branch stable/15 has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=e6b49d71f25932b043575535cbe35c917bd71768 commit e6b49d71f25932b043575535cbe35c917bd71768 Author: Li-Wen Hsu AuthorDate: 2026-06-27 02:26:05 +0000 Commit: Li-Wen Hsu CommitDate: 2026-08-06 01:40:09 +0000 libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode dt_print_sym() fills the symbol string via snprintf() in non-oformat mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf() call causes the symbol is computed but never emitted. This fixes tests: - common.profile-n.t_dtrace_contrib.tst_sym_ksh - common.profile-n.t_dtrace_contrib.tst_func_ksh Reviewed by: markj Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option") MFC after: 3 days Event: Halifax Hackathon 202606 Location: Room 208, Computer Science Building, Dalhousie University Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57895 (cherry picked from commit 8e61d8707f8a10acc143210089fea2502a3f2922) --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c index b311b5425587..a8a49b22ed7b 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c @@ -2143,7 +2143,7 @@ dt_print_sym(dtrace_hdl_t *dtp, FILE *fp, const char *format, caddr_t addr) } } - if (dtp->dt_oformat != 0 && dt_printf(dtp, fp, format, c) < 0) + if (!dtp->dt_oformat && dt_printf(dtp, fp, format, c) < 0) return (-1); return (0);