From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 9 07:40:11 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B630E37B401 for ; Wed, 9 Apr 2003 07:40:11 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73CE043FBF for ; Wed, 9 Apr 2003 07:40:10 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h39EeAUp061572 for ; Wed, 9 Apr 2003 07:40:10 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h39EeA6Y061571; Wed, 9 Apr 2003 07:40:10 -0700 (PDT) Resent-Date: Wed, 9 Apr 2003 07:40:10 -0700 (PDT) Resent-Message-Id: <200304091440.h39EeA6Y061571@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ralf van Dooren Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F36937B401 for ; Wed, 9 Apr 2003 07:31:41 -0700 (PDT) Received: from schaos.xs4all.nl (a80-126-165-169.adsl.xs4all.nl [80.126.165.169]) by mx1.FreeBSD.org (Postfix) with SMTP id 175A643F75 for ; Wed, 9 Apr 2003 07:31:40 -0700 (PDT) (envelope-from root@schaos.xs4all.nl) Received: (qmail 36147 invoked by uid 0); 9 Apr 2003 14:31:38 -0000 Message-Id: <20030409143138.36146.qmail@schaos.xs4all.nl> Date: 9 Apr 2003 14:31:38 -0000 From: Ralf van Dooren To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/50756: ftp/ncftp3 : options in Makefile.local are ignored X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ralf van Dooren List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2003 14:40:12 -0000 >Number: 50756 >Category: ports >Synopsis: ftp/ncftp3 : options in Makefile.local are ignored >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Apr 09 07:40:09 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Ralf van Dooren >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD oerania.mijou.net 4.7-STABLE FreeBSD 4.7-STABLE #1: Thu Dec 26 16:31:23 CET 2002 root@oerania.mijou.net:/usr/obj/usr/src/sys/OERANIA i386 >Description: Options you put in Makefile.local are ignored, for installation. This will cause local settings for ncftp3 to be ignored. oerania# cd /usr/ports/ftp/ncftp3 oerania# echo "INSTALL_AS_NCFTP=yes" > Makefile.local oerania# make -V INSTALL_AS_NCFTP yes oerania# make -V LATEST_LINK ncftp3 oerania# >How-To-Repeat: Enter the above commands. >Fix: By separating bsd.ports.mk into bsd.ports.pre.mk and bsd.ports.post.mk the problem will be fixed. The following patch can be used to correct this: --- Makefile.orig Wed Apr 9 16:07:27 2003 +++ Makefile Wed Apr 9 16:30:56 2003 @@ -20,6 +20,8 @@ MAINTAINER= obrien@FreeBSD.org COMMENT= ftp replacement with advanced user interface +.include + .if defined(INSTALL_AS_NCFTP) LATEST_LINK= ncftp .else @@ -69,4 +71,4 @@ ${PREFIX}/man/man1 @${INSTALL_MAN} ${WRKSRC}/Strn/Strn.3 ${PREFIX}/man/man3 -.include +.include >Release-Note: >Audit-Trail: >Unformatted: