From owner-freebsd-arch@FreeBSD.ORG Tue Feb 3 14:35:28 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD44A16A50D for ; Tue, 3 Feb 2004 14:35:28 -0800 (PST) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4148843D2F for ; Tue, 3 Feb 2004 14:35:16 -0800 (PST) (envelope-from john@baldwin.cx) Received: (qmail 3473 invoked from network); 3 Feb 2004 22:35:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Feb 2004 22:35:15 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i13MZ9M0002617; Tue, 3 Feb 2004 17:35:10 -0500 (EST) (envelope-from john@baldwin.cx) From: John Baldwin To: Pawel Jakub Dawidek , freebsd-arch@freebsd.org Date: Tue, 3 Feb 2004 17:20:20 -0500 User-Agent: KMail/1.5.4 References: <20040203214530.GB14639@garage.freebsd.pl> In-Reply-To: <20040203214530.GB14639@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402031720.20211.john@baldwin.cx> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Subject: Re: Non-standard ;; and SYSINIT(). X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 22:35:28 -0000 On Tuesday 03 February 2004 04:45 pm, Pawel Jakub Dawidek wrote: > Hello. > > It looks like SYSINIT() macro is defined with trailing ;. > Maybe there was some reason to do so, but I assume that this is a bug. > There are many, many calls where an extra ; is added after SYSINIT(). > SYSUNINIT() is defined without trailing ; ... > > This will be ok, but ;; is not supported by ICO C (gcc -pedantic > tell me that). > > Here is a patch that fix this issue at least for SYSINIT(): > > http://garage.freebsd.pl/patches/SYSINIT.patch > > The most important part is a change in sys/kernel.h, that removes > trailing ; from SYSINIT() definition: > > - DATA_SET(sysinit_set,uniquifier ## _sys_init); > + DATA_SET(sysinit_set,uniquifier ## _sys_init) > > AND REMEMBER! I'm not going to commit it (without strong approvals)!:) Yes, please. SYSINIT() without ;'s confuse "smart" editors that try to do autoindent. -- John Baldwin <>< http://www.baldwin.cx/~john/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org