From owner-freebsd-net@FreeBSD.ORG Tue Nov 19 19:28:56 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC988577 for ; Tue, 19 Nov 2013 19:28:56 +0000 (UTC) Received: from mail-bk0-x22b.google.com (mail-bk0-x22b.google.com [IPv6:2a00:1450:4008:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 604E8261B for ; Tue, 19 Nov 2013 19:28:56 +0000 (UTC) Received: by mail-bk0-f43.google.com with SMTP id mz12so1015194bkb.2 for ; Tue, 19 Nov 2013 11:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Azn5t+6PW2QofoW5/3RA0Zgzt0g/kj1eMAr+7W9sflg=; b=oxeq18mRn+hpkgakAchDAYRG2Hy1htPeTHr7DDF7EQ4j4lr6Sk2CTE6OX060K0URjw 8CK+mjgdYE5FVLvam3FwCFwgSYPOTyWAZ+96cUkwyUzKYh/1yZB/RTaJfYI2GA6uQVPR EpY2eiypGZayLVloYkwy0DAr0U1ziooFOeMlE7w905cVQ6ZyDpIY9Wws4Piu7DI0OEEv F0Xs/DlyLMVppTOIe1WjzfjT9TOqCaabmHrzJolDRrLiFl9PXeW8GYEWO4q0BrhTqeC2 SQYq1kSdVOJOg/3mtnlQPMUHmjq7BHHV8waeHQHeRxXrhMKfEzs4im4xPOYNVm/0/0XB +/mg== X-Received: by 10.205.36.193 with SMTP id tb1mr2203532bkb.28.1384889334475; Tue, 19 Nov 2013 11:28:54 -0800 (PST) Received: from omg (pluknet-1-pt.tunnel.tserv11.ams1.ipv6.he.net. [2001:470:1f14:4d0::2]) by mx.google.com with ESMTPSA id l5sm21584475bko.7.2013.11.19.11.28.53 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 19 Nov 2013 11:28:53 -0800 (PST) Sender: Sergey Kandaurov Date: Tue, 19 Nov 2013 23:28:50 +0400 From: Sergey Kandaurov To: Edward O'Callaghan Subject: Re: [PATCH]: Trivial dmesg formatting. Message-ID: <20131119192850.GA97826@omg> References: <20131120044729.14b495d3.eocallaghan@alterapraxis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20131120044729.14b495d3.eocallaghan@alterapraxis.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-net@FreeBSD.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 19:28:56 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 20, 2013 at 04:47:29AM +1100, Edward O'Callaghan wrote: > Index: sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (revision 258349) > +++ sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (working copy) > @@ -182,7 +182,7 @@ > static void > netvsc_init(void) > { > - printf("Netvsc initializing... "); > + printf("Netvsc initializing... \n"); > =20 > /* > * XXXKYS: cleanup initialization Just putting "\n" here is probably not enough to fix formatting. Looking at the code below I think it was done specially so that the line could be appended with "Already initialized!", depending on hyperv and boot state. Personally I'd put the whole thing under bootverbose. --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBAgAGBQJSi7vyAAoJED9Ol7oQYHQZBoMIAK1XK3aiR5/NH/Oa2SEaqOZ1 jD/5o9nTXKGMeX08eymFKM3Hd9C2BUFfhXX+JhC00FCbSBUhhtzmqTWNMUZ1MmpQ AqKnD0wDVdBJvOjUGbmeOaiIEngbQhHmSRQ75/20HzKrMJqy9H3zR9KXwB8Hbmp4 AyhoHckkbcDHUzr2Y40F1Srx3h91kADqaHDoILSnoDNtw1Ibht/+P+kSPR7RQE+K 9k0LwU/uu8bCv4mjoShfJjV2X5Gh3aXkmb71QL54+SG81aSQiXYj3DW110z++CgJ LVZf/4UX3JjzX1lQCjuVRq9Ej1RST16kKseWC1QEN8PUyMGXm0Php33q7moZYjU= =ISQu -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--