From owner-freebsd-current@FreeBSD.ORG  Mon Jul 11 18:42:42 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 20F631065674; Mon, 11 Jul 2011 18:42:42 +0000 (UTC)
Date: Mon, 11 Jul 2011 18:42:42 +0000
From: Alexander Best <arundel@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20110711184242.GA87523@freebsd.org>
References: <201107081511.43417.jhb@freebsd.org>
	<20110709083047.GA86927@freebsd.org>
	<20110709094416.GA95093@freebsd.org>
	<201107111205.13178.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201107111205.13178.jhb@freebsd.org>
Cc: current@freebsd.org, edwin@freebsd.org
Subject: Re: [PATCH] Make top -P an interactive toggle
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2011 18:42:42 -0000

On Mon Jul 11 11, John Baldwin wrote:
> On Saturday, July 09, 2011 5:44:16 am Alexander Best wrote:
> > On Sat Jul  9 11, Alexander Best wrote:
> > > On Fri Jul  8 11, Alexander Best wrote:
> > > > On Fri Jul  8 11, John Baldwin wrote:
> > > > > This patch lets you use 'P' while top is running to toggle between per-CPU and
> > > > > global CPU stats.
> > > > 
> > > > very cool. i always thought that being able to interactivly enable/disable
> > > > per-cpu stats in top would be a useful feature. great to see this being
> > > > implemented.
> > > 
> > > oh...and of course i tested your patch. ;) works great without any issues.
> > 
> > would it be possible to display a note when using 'P'? E.g. when pressing 'z'
> > top informs the user with one of these messages:
> > 
> > "Displaying system idle process."
> > 
> > or
> > 
> > "Not displaying system idle process."
> > 
> > would be nice to have something similar when pressing the 'P' key. Maybe:
> > 
> > "Display per-cpu CPU usage statistics."
> > 
> > and
> > 
> > "Not display per-cpu CPU usage statistics."
> 
> Ok, I went with "Displaying per-CPU statistics" and
> "Displaying global CPU statistics".

cool! thanks. :)

i've discovered a few other top-related issues and will be posting problem
reports and patches throughout the next week.

i also got a mail by bruce evans describing some more issues. since some of
them are pretty techie, i might not be able to provide patches for each one of
them, however i'll try to document them all.

cheers.
alex

> 
> -- 
> John Baldwin