From owner-freebsd-current@FreeBSD.ORG  Wed Sep  3 04:15:01 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DF77316A4BF; Wed,  3 Sep 2003 04:15:01 -0700 (PDT)
Received: from tao.xtaz.co.uk (82-32-29-13.cable.ubr04.azte.blueyonder.co.uk
	[82.32.29.13])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D0EF44402A; Wed,  3 Sep 2003 04:14:59 -0700 (PDT)
	(envelope-from matt@xtaz.co.uk)
Received: from xtaz.co.uk (localhost [127.0.0.1])
	by tao.xtaz.co.uk (Postfix) with ESMTP
	id 927708FC80; Wed,  3 Sep 2003 12:14:52 +0100 (BST)
Message-ID: <3F55CD2C.7070407@xtaz.co.uk>
Date: Wed, 03 Sep 2003 12:14:52 +0100
From: Matt <matt@xtaz.co.uk>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.5b) Gecko/20030827
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Sergey A. Osokin" <osa@FreeBSD.org>
References: <200309031302.01977@harrymail>
	<20030903110830.GR41860@freebsd.org.ru>
In-Reply-To: <20030903110830.GR41860@freebsd.org.ru>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: ports@FreeBSD.org
cc: danfe@regency.nsu.ru
cc: current@freebsd.org
cc: Harald Schmalzbauer <h@schmalzbauer.de>
Subject: Re: [patch] FreeBSD Port: nvidia-driver-1.0.4365
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Sep 2003 11:15:02 -0000

Sergey A. Osokin wrote:

> On Wed, Sep 03, 2003 at 01:01:55PM +0200, Harald Schmalzbauer wrote:
> 
>>with today's -current the nvidia port failed to compile.
>>With a bit luck I found that there seems to be a misstype in the 
>>src/nvidia_sysctl.c. I'm no programmer so I don't know if this has changed 
>>recently or if it has always been an error but the old gcc didn't complain (I 
>>think the former)
>>
>>To make it short: I created patch.aa in files and it works fine with today's 
>>-current.
>>
>>I don't have any -stable so if it is only an 5.x issue there someone shuld 
>>correct the port to make the patch OS-dependent.
>>
>>Please commit the patch.
> 
> 
> Hmm, where is the patch?
> danfe: please review the patch :-)
> 

A constant in one of the kernel header file seems to have been renamed. 
Change PCIR_HEADERTYPE to PCIR_HDRTYPE in nvidia_sysctl.c and all will 
be well.

There is a pr for this which is ports/56157.

Matt.