From owner-svn-src-all@FreeBSD.ORG Mon Oct 5 13:30:31 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 587C91065693; Mon, 5 Oct 2009 13:30:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 2AA2C8FC0A; Mon, 5 Oct 2009 13:30:31 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id C2E0D46B06; Mon, 5 Oct 2009 09:30:30 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (localhost [IPv6:::1]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 69FD08A020; Mon, 5 Oct 2009 09:30:29 -0400 (EDT) Message-ID: <4AC9F4F4.4030008@FreeBSD.org> Date: Mon, 05 Oct 2009 09:30:28 -0400 From: John Baldwin User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Alan Cox References: <200910041853.n94IrAf7082338@svn.freebsd.org> In-Reply-To: <200910041853.n94IrAf7082338@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 05 Oct 2009 09:30:29 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197750 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2009 13:30:31 -0000 Alan Cox wrote: > Author: alc > Date: Sun Oct 4 18:53:10 2009 > New Revision: 197750 > URL: http://svn.freebsd.org/changeset/base/197750 > > Log: > Align and pad the page queue and free page queue locks so that the linker > can't possibly place them together within the same cache line. > > MFC after: 3 weeks > > Modified: > head/sys/vm/vm_page.c > head/sys/vm/vm_page.h > > Modified: head/sys/vm/vm_page.c > ============================================================================== > --- head/sys/vm/vm_page.c Sun Oct 4 17:22:51 2009 (r197749) > +++ head/sys/vm/vm_page.c Sun Oct 4 18:53:10 2009 (r197750) > @@ -135,8 +135,8 @@ __FBSDID("$FreeBSD$"); > */ > > struct vpgqueues vm_page_queues[PQ_COUNT]; > -struct mtx vm_page_queue_mtx; > -struct mtx vm_page_queue_free_mtx; > +struct vpglocks vm_page_queue_lock; > +struct vpglocks vm_page_queue_free_lock; I think you can do this by just: struct mtx vm_page_queue_mtx __aligned(CACHE_LINE_SIZE); without the need for a wrapper structure. -- John Baldwin