From owner-svn-src-head@freebsd.org Sat Oct 15 00:31:22 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 903FEC10D0C; Sat, 15 Oct 2016 00:31:22 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-qt0-x22a.google.com (mail-qt0-x22a.google.com [IPv6:2607:f8b0:400d:c0d::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48D4EC35; Sat, 15 Oct 2016 00:31:22 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-qt0-x22a.google.com with SMTP id f6so88802483qtd.2; Fri, 14 Oct 2016 17:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=USAHVk0rxHop7CuIHdV2Dl535k9UQXuyy/RKFh+S2jk=; b=XUJbh+ESLCEDArKjApfXDfwrlRteAkz+m3ap8Cgtpsb3Q2rWNs8XMibGMnSpAdTBG6 YOXzsdlCUpFGydOWOV2svbKtdDFhKFjcQy6QMwMmfBPPrRSv/57q8NR8Z9Kfbj84wGai AApQHTELw0WSbBqoQSbbDdvWYk6KGKwCl/T6khqPW8D2fZylgOEdfRWWF8YCqqNzvqvl 9l6U87+rIxi0fTOcOD+u9C8xZ0YTx4JhYhHvNXa07roryRncLlk7lwdjM26FInIjYojE ju2QWv4c2GHKyqXfhP0YWr/J7ztIrl5Uy6aEDOgdxAfKzzmuoVgeHgQh0/7K0zwG5Zr1 gzHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=USAHVk0rxHop7CuIHdV2Dl535k9UQXuyy/RKFh+S2jk=; b=SPYLhzfAltQrpAMil/DndnQxszHnnSZVwNpelqRcadEquMrIForuaRFXTixibUbXlC WMJaGoEa0c/I8ww255HZFEVGaZ4y6UZJV5NUPzF2If5WTM/qFpksD7thMyPrpaz++4nA KVunoSJQ0N2MR24StpoRbZ5O+Xk22WLvN3V1iIviTZzGT1a/9L+8AlKQxsCVHOsJEwN1 DLEW2YHTdcEFDb6b1mIvpuYQAwKC9aD+60gzeOAARkKTc90ulvyLxZj1sqPo2pSgzPom ES7yuDy2DxgHfWZXwEtWjGCnBVwm7xk28/CgEzKyLxGLGORrJESLyvSBySMu0MPcLBOc pMvQ== X-Gm-Message-State: AA6/9RnnkVueGr6H3pzHkx6945BppvXhKRhrecE1P7LT9mjl/Yn53nS38bQbRtmiefHAhChwyK2XrFSY5Ab+DQ== X-Received: by 10.200.33.201 with SMTP id 9mr15305921qtz.141.1476491481465; Fri, 14 Oct 2016 17:31:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.53.208 with HTTP; Fri, 14 Oct 2016 17:31:20 -0700 (PDT) In-Reply-To: <20161015000119.GA17390@mutt-hardenedbsd> References: <201610120216.u9C2Gga8041814@repo.freebsd.org> <20161015000119.GA17390@mutt-hardenedbsd> From: Jonathan Looney Date: Fri, 14 Oct 2016 20:31:20 -0400 Message-ID: Subject: Re: svn commit: r307082 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/conf sys/i386/conf sys/mips/conf sys/modules/cc sys/modules/khelp sys/netinet sys/netinet/tcp_stacks sys/pc98/conf sy... To: Shawn Webb Cc: "Jonathan T. Looney" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Oct 2016 00:31:22 -0000 Thanks! Yes, that was clearly an error on my part, and your patch is an obvious solution. I committed it at r307336. Thanks again! Jonathan On Fri, Oct 14, 2016 at 8:01 PM, Shawn Webb wrote: > On Wed, Oct 12, 2016 at 02:16:42AM +0000, Jonathan T. Looney wrote: > > Author: jtl > > Date: Wed Oct 12 02:16:42 2016 > > New Revision: 307082 > > URL: https://svnweb.freebsd.org/changeset/base/307082 > > > > Log: > > In the TCP stack, the hhook(9) framework provides hooks for kernel > modules > > to add actions that run when a TCP frame is sent or received on a TCP > > session in the ESTABLISHED state. In the base tree, this functionality > is > > only used for the h_ertt module, which is used by the cc_cdg, cc_chd, > cc_hd, > > and cc_vegas congestion control modules. > > > > Presently, we incur overhead to check for hooks each time a TCP frame > is > > sent or received on an ESTABLISHED TCP session. > > > > This change adds a new compile-time option (TCP_HHOOK) to determine > whether > > to include the hhook(9) framework for TCP. To retain backwards > > compatibility, I added the TCP_HHOOK option to every configuration > file that > > already defined "options INET". (Therefore, this patch introduces no > > functional change. In order to see a functional difference, you need to > > compile a custom kernel without the TCP_HHOOK option.) This change will > > allow users to easily exclude this functionality from their kernel, > should > > they wish to do so. > > > > Note that any users who use a custom kernel configuration and use one > of the > > congestion control modules listed above will need to add the TCP_HHOOK > > option to their kernel configuration. > > > > Reviewed by: rrs, lstewart, hiren (previous version), sjg > (makefiles only) > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D8185 > > This commit breaks the build when VNET is enabled. Attached is a > candidate patch to fix. > > If the patch doesn't make it to the list, I've pasted it here: > http://ix.io/1wbE > > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE >