Date: Wed, 30 Nov 2011 17:18:20 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r228148 - head/sys/conf Message-ID: <CAGH67wSX1m8K-Dtmsjp-nYm7VzSuRvUE3JTbF9b2CONFqkAu3A@mail.gmail.com> In-Reply-To: <20111201005932.GA54417@freebsd.org> References: <201111292128.pATLSnKr067459@svn.freebsd.org> <20111201005932.GA54417@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 30, 2011 at 4:59 PM, Alexander Best <arundel@freebsd.org> wrote= : > On Tue Nov 29 11, John Baldwin wrote: >> Author: jhb >> Date: Tue Nov 29 21:28:48 2011 >> New Revision: 228148 >> URL: http://svn.freebsd.org/changeset/base/228148 >> >> Log: >> =A0 Remove a bit of debugging that accidentally crept in earlier. >> >> Modified: >> =A0 head/sys/conf/newvers.sh >> >> Modified: head/sys/conf/newvers.sh >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/conf/newvers.sh =A0Tue Nov 29 20:06:27 2011 =A0 =A0 =A0 =A0= (r228147) >> +++ head/sys/conf/newvers.sh =A0Tue Nov 29 21:28:48 2011 =A0 =A0 =A0 =A0= (r228148) >> @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; >> =A0done >> >> =A0if [ -n "$svnversion" ] ; then >> - =A0 =A0 echo "$svnversion" >> =A0 =A0 =A0 svn=3D`cd ${SYSDIR} && $svnversion` > > any chance we could replace $svnversion with something like the following= : > > 'svn info|grep ^Revision|sed 's/^Revision: //'' ? > > this is much faster and the only downside seems to be the missing {MSP} a= t the > end. > > running a standard hdd, svnversion takes almost half a minute, while the > command above finishes in < 0.1 seconds. We already hashed over that in the last discussion. svnversion was picked because it iterates over the entire tree and you know for an absolute fact that it's running versions X-Y-Z, instead of the version of the Makefile being X. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wSX1m8K-Dtmsjp-nYm7VzSuRvUE3JTbF9b2CONFqkAu3A>