From owner-svn-src-all@FreeBSD.ORG Thu Dec 1 01:18:21 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 751D2106566C; Thu, 1 Dec 2011 01:18:21 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id E03978FC15; Thu, 1 Dec 2011 01:18:20 +0000 (UTC) Received: by ywp17 with SMTP id 17so2011628ywp.13 for ; Wed, 30 Nov 2011 17:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=q6zvgi0ZOpZfIeEjkJ7VfXaivGNrajCBK5YZcC44Ebo=; b=j7jo6cF9dTXsGjGZB9//fGgh7mBZCybf7uzXBiEVi552egQcHFnGDqT3LF0FZoEzzE xdPZgGTQT8ozX4cSkYKRWJhHiWuPDTv0NB3wHyUsl2kI1GQRmyNkBINen59Ggcp//S7f wo45xmwSzAn2GzGT81r+uGYrF3SePtjw799RA= MIME-Version: 1.0 Received: by 10.182.218.100 with SMTP id pf4mr1024544obc.12.1322702300351; Wed, 30 Nov 2011 17:18:20 -0800 (PST) Received: by 10.182.62.227 with HTTP; Wed, 30 Nov 2011 17:18:20 -0800 (PST) In-Reply-To: <20111201005932.GA54417@freebsd.org> References: <201111292128.pATLSnKr067459@svn.freebsd.org> <20111201005932.GA54417@freebsd.org> Date: Wed, 30 Nov 2011 17:18:20 -0800 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r228148 - head/sys/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 01:18:21 -0000 On Wed, Nov 30, 2011 at 4:59 PM, Alexander Best wrote= : > On Tue Nov 29 11, John Baldwin wrote: >> Author: jhb >> Date: Tue Nov 29 21:28:48 2011 >> New Revision: 228148 >> URL: http://svn.freebsd.org/changeset/base/228148 >> >> Log: >> =A0 Remove a bit of debugging that accidentally crept in earlier. >> >> Modified: >> =A0 head/sys/conf/newvers.sh >> >> Modified: head/sys/conf/newvers.sh >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/conf/newvers.sh =A0Tue Nov 29 20:06:27 2011 =A0 =A0 =A0 =A0= (r228147) >> +++ head/sys/conf/newvers.sh =A0Tue Nov 29 21:28:48 2011 =A0 =A0 =A0 =A0= (r228148) >> @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; >> =A0done >> >> =A0if [ -n "$svnversion" ] ; then >> - =A0 =A0 echo "$svnversion" >> =A0 =A0 =A0 svn=3D`cd ${SYSDIR} && $svnversion` > > any chance we could replace $svnversion with something like the following= : > > 'svn info|grep ^Revision|sed 's/^Revision: //'' ? > > this is much faster and the only downside seems to be the missing {MSP} a= t the > end. > > running a standard hdd, svnversion takes almost half a minute, while the > command above finishes in < 0.1 seconds. We already hashed over that in the last discussion. svnversion was picked because it iterates over the entire tree and you know for an absolute fact that it's running versions X-Y-Z, instead of the version of the Makefile being X. Thanks, -Garrett