From owner-p4-projects@FreeBSD.ORG Thu Sep 18 12:19:51 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3206A1065683; Thu, 18 Sep 2008 12:19:51 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C85B11065674 for ; Thu, 18 Sep 2008 12:19:50 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B80268FC17 for ; Thu, 18 Sep 2008 12:19:50 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8ICJogN043625 for ; Thu, 18 Sep 2008 12:19:50 GMT (envelope-from ed@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8ICJoLE043623 for perforce@freebsd.org; Thu, 18 Sep 2008 12:19:50 GMT (envelope-from ed@FreeBSD.org) Date: Thu, 18 Sep 2008 12:19:50 GMT Message-Id: <200809181219.m8ICJoLE043623@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to ed@FreeBSD.org using -f From: Ed Schouten To: Perforce Change Reviews Cc: Subject: PERFORCE change 150003 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2008 12:19:51 -0000 http://perforce.freebsd.org/chv.cgi?CH=150003 Change 150003 by ed@ed_dull on 2008/09/18 12:19:24 Just return the [amc]times from the TTY charactr device. Affected files ... .. //depot/projects/mpsafetty/sys/kern/tty_pts.c#20 edit Differences ... ==== //depot/projects/mpsafetty/sys/kern/tty_pts.c#20 (text+ko) ==== @@ -430,6 +430,7 @@ #ifdef PTS_EXTERNAL struct pts_softc *psc = tty_softc(tp); #endif /* PTS_EXTERNAL */ + struct cdev *dev = tp->t_dev; /* * According to POSIX, we must implement an fstat(). This also @@ -437,8 +438,7 @@ * because Linux calls fstat() on the pseudo-terminal master to * obtain st_rdev. * - * XXX: POSIX also mentions we must fill in st_dev, st_atime, - * st_ctime and st_mtime, but how? + * XXX: POSIX also mentions we must fill in st_dev, but how? */ bzero(sb, sizeof *sb); @@ -448,9 +448,13 @@ else #endif /* PTS_EXTERNAL */ sb->st_ino = sb->st_rdev = tty_udev(tp); - sb->st_mode = S_IFCHR; - sb->st_uid = tp->t_dev->si_cred->cr_ruid; - sb->st_gid = GID_TTY; + + sb->st_atimespec = dev->si_atime; + sb->st_ctimespec = dev->si_ctime; + sb->st_mtimespec = dev->si_mtime; + sb->st_uid = dev->si_uid; + sb->st_gid = dev->si_gid; + sb->st_mode = dev->si_mode; return (0); }