From owner-svn-src-head@freebsd.org Sat Jan 6 16:36:31 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A5A4EC1061; Sat, 6 Jan 2018 16:36:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BD0E75D86; Sat, 6 Jan 2018 16:36:30 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 39180466C2; Sat, 6 Jan 2018 17:36:28 +0100 (CET) From: Dimitry Andric Message-Id: <8CD482D7-1C01-480E-A2DE-5B9E1ACF05D4@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r327616 - head/usr.bin/morse Date: Sat, 6 Jan 2018 17:36:27 +0100 In-Reply-To: Cc: Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Eitan Adler References: <201801060948.w069m4Rb058364@repo.freebsd.org> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2018 16:36:31 -0000 --Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 6 Jan 2018, at 14:19, Eitan Adler wrote: >=20 > On 6 January 2018 at 01:48, Li-Wen Hsu wrote: >> Author: lwhsu (ports committer) >> Date: Sat Jan 6 09:48:04 2018 >> New Revision: 327616 >> URL: https://svnweb.freebsd.org/changeset/base/327616 >>=20 >> Log: >> Unbreak build after r327614 >=20 > Why is testing with "make obj; make" in the morse directory = insufficient? >=20 > =E2=88=B4make obj; make > rm -f .depend > echo morse.full: /usr/lib/libc.a >> .depend > cc -O2 -pipe -g -MD -MF.depend.morse.o -MTmorse.o -std=3Dgnu99 > -fstack-protector-strong -Wsystem-headers -Werror -Wall > -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > -Wold-style-definition -Wno-pointer-sign > -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body > -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments > -c morse.c -o morse.o > cc -O2 -pipe -g -std=3Dgnu99 -fstack-protector-strong -Wsystem-headers > -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs > -Wredundant-decls -Wold-style-definition -Wno-pointer-sign > -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body > -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -o > morse.full morse.o > objcopy --only-keep-debug morse.full morse.debug > objcopy --strip-debug --add-gnu-debuglink=3Dmorse.debug morse.full = morse > gzip -cn morse.6 > morse.6.gz Before r327616, I get: usr.bin/morse/morse.c:602:15: error: unused parameter 'stream' = [-Werror,-Wunused-parameter] fdecode(FILE *stream) ^ 1 error generated. Maybe you have warnings turned off in your local build environment? -Dimitry --Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWlD7CwAKCRCwXqMKLiCW ownYAKD6zqug9YWDGAICrc3FEResthNZkACfbH9sqM4pzQYTIqzFDfBJDk5GqLE= =C8du -----END PGP SIGNATURE----- --Apple-Mail=_FBF3A8B0-15AA-46F9-8083-33F4DAB094AF--